[Ash] Use DCHECK in ImeListView::HandleButtonPressed()

[Ash] Use DCHECK in ImeListView::HandleButtonPressed()

Switch the order of calling up to the base class
from within ImeDetailedView::HandleButtonPressed(),
and switch the conditional to a DCHECK in
ImeListView::HandleButtonPressed(); this should be
called if and only if the corresponding toggle button
exists and is clicked.

BUG=686286
TEST=manual

Review-Url: https://codereview.chromium.org/2805733002
Cr-Commit-Position: refs/heads/master@{#464433}
Committed: https://chromium.googlesource.com/chromium/src/+/97a28284f3b297f32f11bbd84c728c07024ae3af

[tdanderson, 2017-04-06 18:06:25]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[tdanderson, 2017-04-06 18:07:02]

tdanderson@chromium.org changed reviewers:
+ estade@chromium.org

[tdanderson, 2017-04-06 18:07:03]

Evan, can you please take a look?

[commit-bot: I haz the power, 2017-04-06 18:07:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 18:44:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 18:44:19]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2017-04-06 19:02:10]

thanks! lgtm

https://codereview.chromium.org/2805733002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/ime_menu/ime_list_view.cc (right):

https://codereview.chromium.org/2805733002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/ime_menu/ime_list_view.cc:312: DCHECK(sender ==
keyboard_status_row_->toggle());
DCHECK_EQ?

[tdanderson, 2017-04-07 18:10:48]

On 2017/04/06 19:02:10, Evan Stade wrote:
> thanks! lgtm
> 
>
https://codereview.chromium.org/2805733002/diff/1/ash/common/system/chromeos/...
> File ash/common/system/chromeos/ime_menu/ime_list_view.cc (right):
> 
>
https://codereview.chromium.org/2805733002/diff/1/ash/common/system/chromeos/...
> ash/common/system/chromeos/ime_menu/ime_list_view.cc:312: DCHECK(sender ==
> keyboard_status_row_->toggle());
> DCHECK_EQ?

FYI I'm holding off until next week to land this, since I want to check
something on an actual device first once my previous CL lands on canary.

[tdanderson, 2017-04-13 15:19:34]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[tdanderson, 2017-04-13 15:20:08]

https://codereview.chromium.org/2805733002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/ime_menu/ime_list_view.cc (right):

https://codereview.chromium.org/2805733002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/ime_menu/ime_list_view.cc:312: DCHECK(sender ==
keyboard_status_row_->toggle());
On 2017/04/06 19:02:10, Evan Stade wrote:
> DCHECK_EQ?

Done.

[commit-bot: I haz the power, 2017-04-13 15:20:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 15:53:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 15:53:02]

Dry run: This issue passed the CQ dry run.

[tdanderson, 2017-04-13 16:17:08]

The CQ bit was checked by tdanderson@chromium.org

[tdanderson, 2017-04-13 16:17:08]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/2805733002/#ps40001
(title: "DCHECK_EQ")

[commit-bot: I haz the power, 2017-04-13 16:17:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 16:28:38]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492100228312310,
"parent_rev": "bc942fdd18c7250065d56f5b51c5441f35d254db", "commit_rev":
"97a28284f3b297f32f11bbd84c728c07024ae3af"}

[commit-bot: I haz the power, 2017-04-13 16:29:38]

Description was changed from

==========
[Ash] Use DCHECK in ImeListView::HandleButtonPressed()

Switch the order of calling up to the base class
from within ImeDetailedView::HandleButtonPressed(),
and switch the conditional to a DCHECK in
ImeListView::HandleButtonPressed(); this should be
called if and only if the corresponding toggle button
exists and is clicked.

BUG=686286
TEST=manual
==========

to

==========
[Ash] Use DCHECK in ImeListView::HandleButtonPressed()

Switch the order of calling up to the base class
from within ImeDetailedView::HandleButtonPressed(),
and switch the conditional to a DCHECK in
ImeListView::HandleButtonPressed(); this should be
called if and only if the corresponding toggle button
exists and is clicked.

BUG=686286
TEST=manual

Review-Url: https://codereview.chromium.org/2805733002
Cr-Commit-Position: refs/heads/master@{#464433}
Committed:
https://chromium.googlesource.com/chromium/src/+/97a28284f3b297f32f11bbd84c72...
==========

[commit-bot: I haz the power, 2017-04-13 16:29:39]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/97a28284f3b297f32f11bbd84c72...