Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2805703002: Remove the bookmark provider from ContentSuggestions (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
Reviewers:
stkhapugin, lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, ntp-dev+reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the bookmark provider from ContentSuggestions The bookmarks are not currently part of ContentSuggestions on iOS. This CL removes the provider from the ContentSuggestionsService used on iOS. BUG=694159 Review-Url: https://codereview.chromium.org/2805703002 Cr-Commit-Position: refs/heads/master@{#462470} Committed: https://chromium.googlesource.com/chromium/src/+/4f6e28eee5894edfb1a5daf79812dafcacb9d93b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
gambard
PTAL.
3 years, 8 months ago (2017-04-06 14:15:04 UTC) #2
gambard
3 years, 8 months ago (2017-04-06 14:37:10 UTC) #8
stkhapugin
lgtm
3 years, 8 months ago (2017-04-06 14:45:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805703002/1
3 years, 8 months ago (2017-04-06 14:45:41 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 14:52:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f6e28eee5894edfb1a5daf79812...

Powered by Google App Engine
This is Rietveld 408576698