Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1482)

Issue 2805673002: CSP: 'strict-dynamic' should allow 'new Worker()' (Closed)

Created:
3 years, 8 months ago by Mike West
Modified:
3 years, 8 months ago
CC:
aaj, blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CSP: 'strict-dynamic' should allow 'new Worker()' This was an oversight when launching 'worker-src'; 'new Worker()' is now covered by 'script-src', and should be allowed in the presence of 'strict-dynamic' (as it has the same properties as any other script execution. BUG=708982 Review-Url: https://codereview.chromium.org/2805673002 Cr-Commit-Position: refs/heads/master@{#462475} Committed: https://chromium.googlesource.com/chromium/src/+/7c484b27809886d417e55bedad7780d62d148c6d

Patch Set 1 #

Patch Set 2 : Fix the test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/external/wpt/content-security-policy/script-src/script-src-strict_dynamic_worker.https.html View 1 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Mike West
Mind taking a look at this, Jochen? +aaj@: FYI.
3 years, 8 months ago (2017-04-06 11:47:09 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-06 12:51:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805673002/20001
3 years, 8 months ago (2017-04-06 13:33:01 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 15:14:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7c484b27809886d417e55bedad77...

Powered by Google App Engine
This is Rietveld 408576698