Disable clickable links in checkbox summary for Talkback

Disable clickable links in checkbox summary for Talkback.

When discussing the UI for CBD, we decided that the main purpose of the checkbox control is to enable/disable the option and we would prefer not to expose the myactivity.google.com link to Talkback. The link will be read out and can be manually entered when required.


BUG=681523
Review-Url: https://codereview.chromium.org/2805643002
Cr-Commit-Position: refs/heads/master@{#477578}
Committed: https://chromium.googlesource.com/chromium/src/+/47741c17bfe4bd58d0e92435f5b2c933fe3a0daa

[dullweber, 2017-04-06 09:42:35]

Description was changed from

==========
Disable clickable links in checkbox summary for Talkback.BUG=681523
==========

to

==========
Disable clickable links in checkbox summary for Talkback.

When discussing the UI for CBD, we decided that the main purpose of the checkbox
is to enable/disable it and we would prefer not to expose the
myactivity.google.com link to talkback. The link will be read out and can be
manually entered when required.


BUG=681523
==========

[dullweber, 2017-04-06 09:46:39]

dullweber@chromium.org changed reviewers:
+ twellington@chromium.org

[dullweber, 2017-04-06 09:46:40]

Hi Theresa,
I talked to Max and we decided that we would prefer if the myactivity.google.com
link is not available when Talkback is activated. We will present this solution
to the accessibility review to see what they think about this.

[dullweber, 2017-04-06 10:41:03]

Description was changed from

==========
Disable clickable links in checkbox summary for Talkback.

When discussing the UI for CBD, we decided that the main purpose of the checkbox
is to enable/disable it and we would prefer not to expose the
myactivity.google.com link to talkback. The link will be read out and can be
manually entered when required.


BUG=681523
==========

to

==========
Disable clickable links in checkbox summary for Talkback.

When discussing the UI for CBD, we decided that the main purpose of the checkbox
control is to enable/disable the option and we would prefer not to expose the
myactivity.google.com link to Talkback. The link will be read out and can be
manually entered when required.


BUG=681523
==========

[Theresa, 2017-04-26 18:34:55]

On 2017/04/06 09:46:40, dullweber wrote:
> Hi Theresa,
> I talked to Max and we decided that we would prefer if the
http://myactivity.google.com
> link is not available when Talkback is activated. We will present this
solution
> to the accessibility review to see what they think about this.

Can you please ask the accessibility team now rather than waiting for a formal
review?

If we're going to turn the link into regular text when accessibility is on (I
think this is really poor experience, but if accessibility signs off I'll allow
it), then the styling needs to be changed so that it doesn't look like a link.

[dullweber, 2017-06-06 15:58:12]

The CQ bit was checked by dullweber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-06 15:58:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dullweber, 2017-06-06 16:01:32]

On 2017/04/26 18:34:55, Theresa wrote:
> On 2017/04/06 09:46:40, dullweber wrote:
> > Hi Theresa,
> > I talked to Max and we decided that we would prefer if the
> http://myactivity.google.com
> > link is not available when Talkback is activated. We will present this
> solution
> > to the accessibility review to see what they think about this.
> 
> Can you please ask the accessibility team now rather than waiting for a formal
> review?
> 
> If we're going to turn the link into regular text when accessibility is on (I
> think this is really poor experience, but if accessibility signs off I'll
allow
> it), then the styling needs to be changed so that it doesn't look like a link.

Hi, 
I'm sorry that this took so long but we finally have accessibility approval and
they didn't think there is an issue if the link is not available to talkback.
(https://bugs.chromium.org/p/chromium/issues/detail?id=718998#c8)
I updated the cl to remove the linkification when accessibility is enabled to
avoid confusion.

[Theresa, 2017-06-06 16:07:22]

lgtm

[commit-bot: I haz the power, 2017-06-06 16:47:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-06 16:47:24]

Dry run: This issue passed the CQ dry run.

[dullweber, 2017-06-07 08:01:28]

The CQ bit was checked by dullweber@chromium.org

[commit-bot: I haz the power, 2017-06-07 08:01:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 08:06:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496822488622010,
"parent_rev": "62ef7ec882c9458a5747a8c819d20285179e0644", "commit_rev":
"47741c17bfe4bd58d0e92435f5b2c933fe3a0daa"}

[commit-bot: I haz the power, 2017-06-07 08:06:14]

Description was changed from

==========
Disable clickable links in checkbox summary for Talkback.

When discussing the UI for CBD, we decided that the main purpose of the checkbox
control is to enable/disable the option and we would prefer not to expose the
myactivity.google.com link to Talkback. The link will be read out and can be
manually entered when required.


BUG=681523
==========

to

==========
Disable clickable links in checkbox summary for Talkback.

When discussing the UI for CBD, we decided that the main purpose of the checkbox
control is to enable/disable the option and we would prefer not to expose the
myactivity.google.com link to Talkback. The link will be read out and can be
manually entered when required.


BUG=681523

Review-Url: https://codereview.chromium.org/2805643002
Cr-Commit-Position: refs/heads/master@{#477578}
Committed:
https://chromium.googlesource.com/chromium/src/+/47741c17bfe4bd58d0e92435f5b2...
==========

[commit-bot: I haz the power, 2017-06-07 08:06:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/47741c17bfe4bd58d0e92435f5b2...