Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2805623002: gpu: Notify callbacks the reason for channel creation failure (Closed)

Created:
3 years, 8 months ago by sadrul
Modified:
3 years, 8 months ago
Reviewers:
piman
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Notify callbacks the reason for channel creation failure. Notify the callers of GpuProcessHost::EstablishGpuChannel() why the request failed, so that they can easily determine whether it is necessary to make a second request. BUG=709332 Review-Url: https://codereview.chromium.org/2805623002 Cr-Commit-Position: refs/heads/master@{#463081} Committed: https://chromium.googlesource.com/chromium/src/+/98c8321fe910ef7b8ce02bb9f304191c835a5b11

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -60 lines) Patch
M content/browser/gpu/browser_gpu_channel_host_factory.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 1 2 8 chunks +23 lines, -49 lines 0 comments Download
M content/browser/gpu/gpu_client.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_client.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 2 1 chunk +12 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 3 3 chunks +8 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 25 (20 generated)
piman
https://codereview.chromium.org/2805623002/diff/20001/content/browser/gpu/browser_gpu_channel_host_factory.cc File content/browser/gpu/browser_gpu_channel_host_factory.cc (right): https://codereview.chromium.org/2805623002/diff/20001/content/browser/gpu/browser_gpu_channel_host_factory.cc#newcode99 content/browser/gpu/browser_gpu_channel_host_factory.cc:99: gpu_host_id_(gpu_host_id), I think we don't need this one any ...
3 years, 8 months ago (2017-04-06 18:16:39 UTC) #8
sadrul
https://codereview.chromium.org/2805623002/diff/20001/content/browser/gpu/browser_gpu_channel_host_factory.cc File content/browser/gpu/browser_gpu_channel_host_factory.cc (right): https://codereview.chromium.org/2805623002/diff/20001/content/browser/gpu/browser_gpu_channel_host_factory.cc#newcode99 content/browser/gpu/browser_gpu_channel_host_factory.cc:99: gpu_host_id_(gpu_host_id), On 2017/04/06 18:16:39, piman wrote: > I think ...
3 years, 8 months ago (2017-04-07 04:10:53 UTC) #16
piman
lgtm
3 years, 8 months ago (2017-04-07 18:01:32 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805623002/60001
3 years, 8 months ago (2017-04-07 23:39:40 UTC) #22
commit-bot: I haz the power
3 years, 8 months ago (2017-04-08 00:51:21 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/98c8321fe910ef7b8ce02bb9f304...

Powered by Google App Engine
This is Rietveld 408576698