Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2805613002: [turbofan] Bump the fast literal properties budget for JSCreateLowering. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Bump the fast literal properties budget for JSCreateLowering. We have a weird performance cliff, where using an object literal for allocation is way slower than using a constructor function, or starting from the empty object literal and using transitioning stores. The reason is that we limit the inlining of JSCreateLiteralObject nodes in TurboFan to max. 8 fast properties. So as soon as you get above 8, you'll get a runtime function call to %CreateObjectLiteral, which is a lot slower than the inlined allocation and initialization. Still not ideal, but less unpredictable (hopefully). R=jarin@chromium.org BUG=v8:6211 Review-Url: https://codereview.chromium.org/2805613002 Cr-Commit-Position: refs/heads/master@{#44424} Committed: https://chromium.googlesource.com/v8/v8/+/bff3b266d23cf0054e687b150f949acc6ce2e1a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/compiler/js-create-lowering.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-06 05:35:27 UTC) #1
Jarin
lgtm
3 years, 8 months ago (2017-04-06 05:44:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805613002/1
3 years, 8 months ago (2017-04-06 05:44:55 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 06:01:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/bff3b266d23cf0054e687b150f949acc6ce...

Powered by Google App Engine
This is Rietveld 408576698