Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2805563002: Change wpt_expectations_updater to not depend on TestParser. (Closed)

Created:
3 years, 8 months ago by qyearsley
Modified:
3 years, 8 months ago
Reviewers:
tkent, jeffcarp
CC:
tkent, blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change wpt_expectations_updater to not depend on TestParser. Background: In order to tell which tests to download -expected.txt files for and which tests to update expectations for, wpt-update-expectations checks the type of the test. Previously TestParser was used to do this, but I want to get rid of TestParser. This CL replaces TestParser by checking whether a test is a ref tests by calling port.reference_files, which in turn checks the MANIFEST.json for tests in external/wpt. Review-Url: https://codereview.chromium.org/2805563002 Cr-Commit-Position: refs/heads/master@{#463296} Committed: https://chromium.googlesource.com/chromium/src/+/a9199c53b3525282ba88265be606efe81c2c8477

Patch Set 1 #

Patch Set 2 : Finish updating test and fix code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -95 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py View 1 6 chunks +16 lines, -24 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater_unittest.py View 1 15 chunks +81 lines, -71 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
qyearsley
3 years, 8 months ago (2017-04-06 22:42:17 UTC) #4
qyearsley
3 years, 8 months ago (2017-04-07 21:40:43 UTC) #9
tkent
lgtm
3 years, 8 months ago (2017-04-09 23:26:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805563002/20001
3 years, 8 months ago (2017-04-10 15:42:11 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 16:51:44 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a9199c53b3525282ba88265be606...

Powered by Google App Engine
This is Rietveld 408576698