Null-check the dialog delegate in the modal permission dialog dismiss handler.

Null-check the dialog delegate in the modal permission dialog dismiss handler.

This is a speculative fix for a crash bug on Android where the delegate
somehow ends up null. This CL adds a null check that skips interacting
with the delegate in this situation (if it is null, native must have
been freed).

BUG=708562
Review-Url: https://codereview.chromium.org/2805543004
Cr-Commit-Position: refs/heads/master@{#462665}
Committed: https://chromium.googlesource.com/chromium/src/+/a8d5da58d57f52809aca3b835c4268a04ed1a0ca

[dominickn, 2017-04-06 05:48:30]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[dominickn, 2017-04-06 05:50:06]

dominickn@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[dominickn, 2017-04-06 05:50:06]

PTAL, thanks!

[commit-bot: I haz the power, 2017-04-06 05:51:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 06:53:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 06:53:06]

Dry run: This issue passed the CQ dry run.

[gone, 2017-04-06 17:41:39]

lgtm

[dominickn, 2017-04-06 22:40:33]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2017-04-06 22:41:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 22:52:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491518433195560, "parent_rev":
"55a232ae66f6f48e6cc1ac904693d905850f19a3", "commit_rev":
"a8d5da58d57f52809aca3b835c4268a04ed1a0ca"}

[commit-bot: I haz the power, 2017-04-06 22:53:16]

Description was changed from

==========
Null-check the dialog delegate in the modal permission dialog dismiss handler.

This is a speculative fix for a crash bug on Android where the delegate
somehow ends up null. This CL adds a null check that skips interacting
with the delegate in this situation (if it is null, native must have
been freed).

BUG=708562
==========

to

==========
Null-check the dialog delegate in the modal permission dialog dismiss handler.

This is a speculative fix for a crash bug on Android where the delegate
somehow ends up null. This CL adds a null check that skips interacting
with the delegate in this situation (if it is null, native must have
been freed).

BUG=708562

Review-Url: https://codereview.chromium.org/2805543004
Cr-Commit-Position: refs/heads/master@{#462665}
Committed:
https://chromium.googlesource.com/chromium/src/+/a8d5da58d57f52809aca3b835c42...
==========

[commit-bot: I haz the power, 2017-04-06 22:53:17]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a8d5da58d57f52809aca3b835c42...

[Timothy Loh, 2017-05-10 07:38:36]

timloh@chromium.org changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2017-05-10 07:38:37]

https://codereview.chromium.org/2805543004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java
(right):

https://codereview.chromium.org/2805543004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java:196:
scheduleDisplay();
Was there supposed to be a return here?

[dominickn, 2017-05-10 08:42:15]

https://codereview.chromium.org/2805543004/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java
(right):

https://codereview.chromium.org/2805543004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/permissions/PermissionDialogController.java:196:
scheduleDisplay();
On 2017/05/10 07:38:37, Timothy Loh wrote:
> Was there supposed to be a return here?

Hmmmmmmm.... yes. I think so. Oops.