Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2805543002: [DevTools] When adjusting glass pane's content width for arrow, do not comporomise the size (Closed)

Created:
3 years, 8 months ago by dgozman
Modified:
3 years, 8 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] When adjusting glass pane's content width for arrow, do not comporomise the size When we don't have enough height but want an arrow, we adjusted the position to leave some space under cursor. This should not make the content shrink, so account for the content width in calculations. BUG=706719 Review-Url: https://codereview.chromium.org/2805543002 Cr-Commit-Position: refs/heads/master@{#462334} Committed: https://chromium.googlesource.com/chromium/src/+/647d3778e7f445c6d4ba9ca9a822278cd63bf839

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dgozman
Could you please take a look?
3 years, 8 months ago (2017-04-06 00:24:06 UTC) #2
lushnikov
lgtm
3 years, 8 months ago (2017-04-06 01:09:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805543002/1
3 years, 8 months ago (2017-04-06 01:10:19 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 02:47:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/647d3778e7f445c6d4ba9ca9a822...

Powered by Google App Engine
This is Rietveld 408576698