Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4825)

Unified Diff: chrome/browser/speech/extension_api/tts_extension_apitest.cc

Issue 2805533004: Disable TtsApiTest.EngineError browser test on most OS-es (due to flakiness). (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/speech/extension_api/tts_extension_apitest.cc
diff --git a/chrome/browser/speech/extension_api/tts_extension_apitest.cc b/chrome/browser/speech/extension_api/tts_extension_apitest.cc
index eb5cfbfda8325a6ec514126fea672659b24e2ca1..9911653e4da0a4de11e6cbf35559333e39e2cd51 100644
--- a/chrome/browser/speech/extension_api/tts_extension_apitest.cc
+++ b/chrome/browser/speech/extension_api/tts_extension_apitest.cc
@@ -411,7 +411,13 @@ IN_PROC_BROWSER_TEST_F(TtsApiTest, RegisterEngine) {
ASSERT_TRUE(RunExtensionTest("tts_engine/register_engine")) << message_;
}
-IN_PROC_BROWSER_TEST_F(TtsApiTest, EngineError) {
+// https://crbug.com/709115 tracks test flakiness.
+#if defined(OS_POSIX)
+#define MAYBE_EngineError DISABLED_EngineError
+#else
+#define MAYBE_EngineError EngineError
+#endif
+IN_PROC_BROWSER_TEST_F(TtsApiTest, MAYBE_EngineError) {
EXPECT_CALL(mock_platform_impl_, IsSpeaking());
EXPECT_CALL(mock_platform_impl_, StopSpeaking())
.WillRepeatedly(Return(true));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698