Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: chrome/browser/speech/extension_api/tts_extension_apitest.cc

Issue 2805533004: Disable TtsApiTest.EngineError browser test on most OS-es (due to flakiness). (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/location.h" 9 #include "base/location.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 393 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 EXPECT_CALL(mock_platform_impl_, Speak(_, "native speech 3", _, _, _)) 404 EXPECT_CALL(mock_platform_impl_, Speak(_, "native speech 3", _, _, _))
405 .WillOnce(DoAll( 405 .WillOnce(DoAll(
406 Invoke(&mock_platform_impl_, 406 Invoke(&mock_platform_impl_,
407 &MockTtsPlatformImpl::SendEndEvent), 407 &MockTtsPlatformImpl::SendEndEvent),
408 Return(true))); 408 Return(true)));
409 } 409 }
410 410
411 ASSERT_TRUE(RunExtensionTest("tts_engine/register_engine")) << message_; 411 ASSERT_TRUE(RunExtensionTest("tts_engine/register_engine")) << message_;
412 } 412 }
413 413
414 IN_PROC_BROWSER_TEST_F(TtsApiTest, EngineError) { 414 // https://crbug.com/709115 tracks test flakiness.
415 #if defined(OS_POSIX)
416 #define MAYBE_EngineError DISABLED_EngineError
417 #else
418 #define MAYBE_EngineError EngineError
419 #endif
420 IN_PROC_BROWSER_TEST_F(TtsApiTest, MAYBE_EngineError) {
415 EXPECT_CALL(mock_platform_impl_, IsSpeaking()); 421 EXPECT_CALL(mock_platform_impl_, IsSpeaking());
416 EXPECT_CALL(mock_platform_impl_, StopSpeaking()) 422 EXPECT_CALL(mock_platform_impl_, StopSpeaking())
417 .WillRepeatedly(Return(true)); 423 .WillRepeatedly(Return(true));
418 424
419 ASSERT_TRUE(RunExtensionTest("tts_engine/engine_error")) << message_; 425 ASSERT_TRUE(RunExtensionTest("tts_engine/engine_error")) << message_;
420 } 426 }
421 427
422 IN_PROC_BROWSER_TEST_F(TtsApiTest, EngineWordCallbacks) { 428 IN_PROC_BROWSER_TEST_F(TtsApiTest, EngineWordCallbacks) {
423 EXPECT_CALL(mock_platform_impl_, IsSpeaking()); 429 EXPECT_CALL(mock_platform_impl_, IsSpeaking());
424 EXPECT_CALL(mock_platform_impl_, StopSpeaking()) 430 EXPECT_CALL(mock_platform_impl_, StopSpeaking())
(...skipping 28 matching lines...) Expand all
453 // Test should fail when offline. 459 // Test should fail when offline.
454 ASSERT_FALSE(RunExtensionTest("tts_engine/network_speech_engine")); 460 ASSERT_FALSE(RunExtensionTest("tts_engine/network_speech_engine"));
455 } 461 }
456 462
457 // http://crbug.com/122474 463 // http://crbug.com/122474
458 IN_PROC_BROWSER_TEST_F(TtsApiTest, EngineApi) { 464 IN_PROC_BROWSER_TEST_F(TtsApiTest, EngineApi) {
459 ASSERT_TRUE(RunExtensionTest("tts_engine/engine_api")) << message_; 465 ASSERT_TRUE(RunExtensionTest("tts_engine/engine_api")) << message_;
460 } 466 }
461 467
462 } // namespace extensions 468 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698