Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h

Issue 2805493002: Boolean properties for Accessibility Object Model Phase 1 (Closed)
Patch Set: Back to previous patchset, ready to land Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
diff --git a/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h b/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
index 789a85ce4b4eded5220e020bbcd891507b959316..51cb7309a7e9538b28df1388e074ef5e4fe68f85 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
+++ b/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.h
@@ -54,6 +54,7 @@ class Node;
class LayoutObject;
class ScrollableArea;
+enum class AOMBooleanProperty;
enum class AOMStringProperty;
typedef unsigned AXID;
@@ -608,9 +609,10 @@ class MODULES_EXPORT AXObjectImpl
// Wrappers that retrieve either an Accessibility Object Model property,
// or the equivalent ARIA attribute, in that order.
- // TODO(dmazzoni): Add equivalents for other types of properties besides
- // just strings.
const AtomicString& GetAOMPropertyOrARIAAttribute(AOMStringProperty) const;
+ bool HasAOMPropertyOrARIAAttribute(AOMBooleanProperty, bool& result) const;
+ bool AOMPropertyOrARIAAttributeIsTrue(AOMBooleanProperty) const;
+ bool AOMPropertyOrARIAAttributeIsFalse(AOMBooleanProperty) const;
virtual void GetSparseAXAttributes(AXSparseAttributeClient&) const {}
@@ -984,12 +986,13 @@ class MODULES_EXPORT AXObjectImpl
virtual double EstimatedLoadingProgress() const { return 0; }
// DOM and layout tree access.
- virtual Node* GetNode() const { return 0; }
- virtual LayoutObject* GetLayoutObject() const { return 0; }
+ virtual Node* GetNode() const { return nullptr; }
+ virtual Element* GetElement() const; // Same as GetNode, if it's an Element.
+ virtual LayoutObject* GetLayoutObject() const { return nullptr; }
virtual Document* GetDocument() const;
virtual FrameView* DocumentFrameView() const;
- virtual Element* AnchorElement() const { return 0; }
- virtual Element* ActionElement() const { return 0; }
+ virtual Element* AnchorElement() const { return nullptr; }
+ virtual Element* ActionElement() const { return nullptr; }
String Language() const;
bool HasAttribute(const QualifiedName&) const;
const AtomicString& GetAttribute(const QualifiedName&) const;

Powered by Google App Engine
This is Rietveld 408576698