Add a const version of JSONObject::cast()

Add a const version of JSONObject::cast()

Review-Url: https://codereview.chromium.org/2805473002
Cr-Commit-Position: refs/heads/master@{#462217}
Committed: https://chromium.googlesource.com/chromium/src/+/fe8f0148d313bfa9259d41eeba8da48c7d7dbc25

[wychen, 2017-04-05 18:47:21]

The CQ bit was checked by wychen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 18:47:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wychen, 2017-04-05 18:49:01]

wychen@chromium.org changed reviewers:
+ iclelland@chromium.org

[wychen, 2017-04-05 18:49:01]

PTAL

[wychen, 2017-04-05 18:51:12]

This is to be used in https://codereview.chromium.org/2793103002/.

[iclelland, 2017-04-05 19:08:51]

This overload makes sense; casting const* to const* should be const :)

lgtm

[wychen, 2017-04-05 19:43:10]

On 2017/04/05 19:08:51, iclelland wrote:
> This overload makes sense; casting const* to const* should be const :)

Just to clarify. When you said "casting const* to const* should be const", did
you mean the function itself should be a const member function? But that's a
static function.

[iclelland, 2017-04-05 19:48:31]

On 2017/04/05 19:43:10, wychen wrote:
> On 2017/04/05 19:08:51, iclelland wrote:
> > This overload makes sense; casting const* to const* should be const :)
> 
> Just to clarify. When you said "casting const* to const* should be const", did
> you mean the function itself should be a const member function? But that's a
> static function.

Sorry, I mistyped -- I meant to say that it should be valid; I don't know how my
fingers ended up typing 'const' a third time there.

[commit-bot: I haz the power, 2017-04-05 20:44:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 20:44:22]

Dry run: This issue passed the CQ dry run.

[wychen, 2017-04-05 21:05:48]

The CQ bit was checked by wychen@chromium.org

[commit-bot: I haz the power, 2017-04-05 21:07:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wychen, 2017-04-05 21:11:06]

On 2017/04/05 19:48:31, iclelland wrote:
> On 2017/04/05 19:43:10, wychen wrote:
> > On 2017/04/05 19:08:51, iclelland wrote:
> > > This overload makes sense; casting const* to const* should be const :)
> > 
> > Just to clarify. When you said "casting const* to const* should be const",
did
> > you mean the function itself should be a const member function? But that's a
> > static function.
> 
> Sorry, I mistyped -- I meant to say that it should be valid; I don't know how
my
> fingers ended up typing 'const' a third time there.

Got it. Thanks! :)

[commit-bot: I haz the power, 2017-04-05 21:16:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491426348695580, "parent_rev":
"7f7bae62d5928d1da3e0d100d5f4215bfce61a87", "commit_rev":
"fe8f0148d313bfa9259d41eeba8da48c7d7dbc25"}

[commit-bot: I haz the power, 2017-04-05 21:18:19]

Description was changed from

==========
Add a const version of JSONObject::cast()
==========

to

==========
Add a const version of JSONObject::cast()

Review-Url: https://codereview.chromium.org/2805473002
Cr-Commit-Position: refs/heads/master@{#462217}
Committed:
https://chromium.googlesource.com/chromium/src/+/fe8f0148d313bfa9259d41eeba8d...
==========

[commit-bot: I haz the power, 2017-04-05 21:18:21]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fe8f0148d313bfa9259d41eeba8d...