Adding ArcBridge interface for synchronizing brightness settings

chromeos/dbus/power_manager_client.cc

Index: chromeos/dbus/power_manager_client.cc
diff --git a/chromeos/dbus/power_manager_client.cc b/chromeos/dbus/power_manager_client.cc
index 2ee1a195e42d04e356eff8206be6996c6852147d..7efda5ac65d522494029c66985786c178766be1e 100644
--- a/chromeos/dbus/power_manager_client.cc
+++ b/chromeos/dbus/power_manager_client.cc
@@ -186,6 +186,17 @@ class PowerManagerClientImpl : public PowerManagerClient {
                    weak_ptr_factory_.GetWeakPtr(), callback));
   }
 
+  void SyncScreenBrightness() override {
+    GetScreenBrightnessPercent(
+        base::Bind(&PowerManagerClientImpl::NotifyBrightnessChanges,
+                   weak_ptr_factory_.GetWeakPtr()));
+  }

[Daniel Erat, 2017/04/05 21:47:21]

adding a new method isn't the right way to do this.

if your code needs to get the current brightness from powerd, it should call the
existing GetScreenBrightnessPercent method. it doesn't make sense to add a new
SyncScreenBrightness method that just calls the existing public method.

(i see that luis left a comment on another file suggesting the same approach.)

[yueli, 2017/04/05 23:27:17]

Done.

+
+  void NotifyBrightnessChanges(double percent) {
+    for (auto& observer : observers_)
+      observer.BrightnessChanged(static_cast<int>(percent), false);
+  }
+
   void RequestStatusUpdate() override {
     POWER_LOG(USER) << "RequestStatusUpdate";
     dbus::MethodCall method_call(