Adding ArcBridge interface for synchronizing brightness settings

chromeos/dbus/power_manager_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/power_manager_client.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 168 matching lines @@
     dbus::MethodCall method_call(
         power_manager::kPowerManagerInterface,
         power_manager::kGetScreenBrightnessPercentMethod);
     power_manager_proxy_->CallMethod(
         &method_call,
         dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
         base::Bind(&PowerManagerClientImpl::OnGetScreenBrightnessPercent,
                    weak_ptr_factory_.GetWeakPtr(), callback));
   }
 
+  void SyncScreenBrightness() override {
+    GetScreenBrightnessPercent(
+        base::Bind(&PowerManagerClientImpl::NotifyBrightnessChanges,
+                   weak_ptr_factory_.GetWeakPtr()));
+  }

[Daniel Erat, 2017/04/05 21:47:21]

adding a new method isn't the right way to do this.

if your code needs to get the current brightness from powerd, it should call the
existing GetScreenBrightnessPercent method. it doesn't make sense to add a new
SyncScreenBrightness method that just calls the existing public method.

(i see that luis left a comment on another file suggesting the same approach.)

[yueli, 2017/04/05 23:27:17]

Done.

+
+  void NotifyBrightnessChanges(double percent) {
+    for (auto& observer : observers_)
+      observer.BrightnessChanged(static_cast<int>(percent), false);
+  }
+
   void RequestStatusUpdate() override {
     POWER_LOG(USER) << "RequestStatusUpdate";
     dbus::MethodCall method_call(
         power_manager::kPowerManagerInterface,
         power_manager::kGetPowerSupplyPropertiesMethod);
     power_manager_proxy_->CallMethod(
         &method_call,
         dbus::ObjectProxy::TIMEOUT_USE_DEFAULT,
         base::Bind(&PowerManagerClientImpl::OnGetPowerSupplyPropertiesMethod,
                    weak_ptr_factory_.GetWeakPtr()));
@@ skipping 744 matching lines @@
 // static
 PowerManagerClient* PowerManagerClient::Create(
     DBusClientImplementationType type) {
   if (type == REAL_DBUS_CLIENT_IMPLEMENTATION)
     return new PowerManagerClientImpl();
   DCHECK_EQ(FAKE_DBUS_CLIENT_IMPLEMENTATION, type);
   return new FakePowerManagerClient();
 }
 
 }  // namespace chromeos