|
|
Created:
3 years, 8 months ago by Mircea Trofin Modified:
3 years, 8 months ago Reviewers:
haraken CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[wasm] Removed redundant promise resolution in wasm bindings
Promise resoution was made redundant after last refactoring.
BUG=
Review-Url: https://codereview.chromium.org/2805403002
Cr-Commit-Position: refs/heads/master@{#463159}
Committed: https://chromium.googlesource.com/chromium/src/+/d947824f59377a43781ea4aa3ee188a995e71734
Patch Set 1 #Patch Set 2 : Post - blink-reformat. #Messages
Total messages: 23 (17 generated)
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [wasm] Removed some redundant lines. BUG= ========== to ========== [wasm] Removed some redundant lines from wasm bindings. BUG= ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [wasm] Removed some redundant lines from wasm bindings. BUG= ========== to ========== [wasm] Removed redundant promise resolution in wasm bindings Promise resoution was made redundant after last refactoring. BUG= ==========
mtrofin@chromium.org changed reviewers: + haraken@chromium.org
LGTM
The CQ bit was checked by mtrofin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/Source/bindings/modules/v8/wasm/WasmResponseExtensions.cpp: While running git apply --index -3 -p1; error: patch failed: third_party/WebKit/Source/bindings/modules/v8/wasm/WasmResponseExtensions.cpp:207 Falling back to three-way merge... Applied patch to 'third_party/WebKit/Source/bindings/modules/v8/wasm/WasmResponseExtensions.cpp' with conflicts. U third_party/WebKit/Source/bindings/modules/v8/wasm/WasmResponseExtensions.cpp Patch: third_party/WebKit/Source/bindings/modules/v8/wasm/WasmResponseExtensions.cpp Index: third_party/WebKit/Source/bindings/modules/v8/wasm/WasmResponseExtensions.cpp diff --git a/third_party/WebKit/Source/bindings/modules/v8/wasm/WasmResponseExtensions.cpp b/third_party/WebKit/Source/bindings/modules/v8/wasm/WasmResponseExtensions.cpp index a2a8dc1d30d475bbcbe8999be128113a37b731a9..d1b67a30d631b147a110a7bcc929a099550c5ac3 100644 --- a/third_party/WebKit/Source/bindings/modules/v8/wasm/WasmResponseExtensions.cpp +++ b/third_party/WebKit/Source/bindings/modules/v8/wasm/WasmResponseExtensions.cpp @@ -207,21 +207,16 @@ bool wasmCompileOverload(const v8::FunctionCallbackInfo<v8::Value>& args) { v8::Local<v8::Function> compileCallback = v8::Function::New(isolate, compileFromResponseCallback); - ScriptPromiseResolver* scriptPromiseResolver = - ScriptPromiseResolver::create(scriptState); // treat either case of parameter as // Promise.resolve(parameter) // as per https://www.w3.org/2001/tag/doc/promises-guide#resolve-arguments // Ending with: // return Promise.resolve(parameter).then(compileCallback); - ScriptPromise parameterAsPromise = scriptPromiseResolver->promise(); v8SetReturnValue(args, ScriptPromise::cast(scriptState, args[0]) .then(compileCallback) .v8Value()); - // resolve the first parameter promise. - scriptPromiseResolver->resolve(ScriptValue::from(scriptState, args[0])); return true; }
The CQ bit was checked by mtrofin@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2805403002/#ps20001 (title: "Post - blink-reformat.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491778667370930, "parent_rev": "fe0ca7ee74c3e2071b7298a03482609441e35a52", "commit_rev": "d947824f59377a43781ea4aa3ee188a995e71734"}
Message was sent while issue was closed.
Description was changed from ========== [wasm] Removed redundant promise resolution in wasm bindings Promise resoution was made redundant after last refactoring. BUG= ========== to ========== [wasm] Removed redundant promise resolution in wasm bindings Promise resoution was made redundant after last refactoring. BUG= Review-Url: https://codereview.chromium.org/2805403002 Cr-Commit-Position: refs/heads/master@{#463159} Committed: https://chromium.googlesource.com/chromium/src/+/d947824f59377a43781ea4aa3ee1... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/d947824f59377a43781ea4aa3ee1... |