Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2805403002: [wasm] Removed redundant promise resolution in wasm bindings (Closed)

Created:
3 years, 8 months ago by Mircea Trofin
Modified:
3 years, 8 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[wasm] Removed redundant promise resolution in wasm bindings Promise resoution was made redundant after last refactoring. BUG= Review-Url: https://codereview.chromium.org/2805403002 Cr-Commit-Position: refs/heads/master@{#463159} Committed: https://chromium.googlesource.com/chromium/src/+/d947824f59377a43781ea4aa3ee188a995e71734

Patch Set 1 #

Patch Set 2 : Post - blink-reformat. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M third_party/WebKit/Source/bindings/modules/v8/wasm/WasmResponseExtensions.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
Mircea Trofin
3 years, 8 months ago (2017-04-09 13:29:48 UTC) #12
haraken
LGTM
3 years, 8 months ago (2017-04-09 13:57:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805403002/1
3 years, 8 months ago (2017-04-09 13:59:30 UTC) #15
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/bindings/modules/v8/wasm/WasmResponseExtensions.cpp: While running git apply --index -3 -p1; error: patch ...
3 years, 8 months ago (2017-04-09 22:01:41 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805403002/20001
3 years, 8 months ago (2017-04-09 22:58:02 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 00:40:20 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d947824f59377a43781ea4aa3ee1...

Powered by Google App Engine
This is Rietveld 408576698