Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2805353003: Upstream navigator.storage.persist()/persisted() tests to WPT (Closed)

Created:
3 years, 8 months ago by jsbell
Modified:
3 years, 8 months ago
Reviewers:
pwnall
CC:
chromium-reviews, blink-reviews, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream navigator.storage.persist()/persisted() tests to WPT The tests just assert that the methods return promises and that the promises resolve to booleans. TODO: Replace the *.worker.html files with just *.worker.js once Blink supports running those. BUG=692147 Review-Url: https://codereview.chromium.org/2805353003 Cr-Commit-Position: refs/heads/master@{#463062} Committed: https://chromium.googlesource.com/chromium/src/+/890c567c988debbe7d456765fdbc202d01571cf8

Patch Set 1 #

Messages

Total messages: 15 (9 generated)
jsbell
pwnall@ - can you review?
3 years, 8 months ago (2017-04-07 21:27:31 UTC) #2
pwnall
LGTM. Out of curiosity --- any interesting reason why you preferred var over const?
3 years, 8 months ago (2017-04-07 23:51:56 UTC) #7
jsbell
On 2017/04/07 23:51:56, pwnall wrote: > Out of curiosity --- any interesting reason why you ...
3 years, 8 months ago (2017-04-07 23:56:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805353003/1
3 years, 8 months ago (2017-04-07 23:57:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/890c567c988debbe7d456765fdbc202d01571cf8
3 years, 8 months ago (2017-04-08 00:09:39 UTC) #14
pwnall
3 years, 8 months ago (2017-04-08 00:30:47 UTC) #15
Message was sent while issue was closed.
On 2017/04/07 23:56:49, jsbell wrote:
> On 2017/04/07 23:51:56, pwnall wrote:
> > Out of curiosity --- any interesting reason why you preferred var over
const?
> 
> I was trying not to monkey with the tests too much. I could go back and ES6ify
> them.

No need, this is a good answer for me. Thank you for explaining!

Powered by Google App Engine
This is Rietveld 408576698