Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 2805353002: Merge 58: Handle HW encoder errors in VideoTrackRecorder (Closed)

Created:
3 years, 8 months ago by emircan
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Merge 58: Handle HW encoder errors in VideoTrackRecorder This CL adds callback to propagate errors from VEAEncoder to VideoTrackRecorder so that the recording session can be reinitialized. BUG=676424 TEST=Added unittest. WebRTC quality browser tests now pass on Mac H264. Review-Url: https://codereview.chromium.org/2804843002 Cr-Commit-Position: refs/heads/master@{#462366} (cherry picked from commit 75762009cfc628424a8af508b91418ce912e0506) NOTRY=true NOPRESUBMIT=true TBR=mcasas@chromium.org Review-Url: https://codereview.chromium.org/2805353002 Cr-Commit-Position: refs/branch-heads/3029@{#632} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/3d814aa227e5c0b125b53ec0b57ee3ff25f4acf4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -9 lines) Patch
M content/renderer/media_recorder/video_track_recorder.h View 3 chunks +5 lines, -1 line 0 comments Download
M content/renderer/media_recorder/video_track_recorder.cc View 10 chunks +37 lines, -8 lines 0 comments Download
M content/renderer/media_recorder/video_track_recorder_unittest.cc View 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805353002/1
3 years, 8 months ago (2017-04-07 20:43:57 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 21:06:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3d814aa227e5c0b125b53ec0b57e...

Powered by Google App Engine
This is Rietveld 408576698