Compute accessible name of objects with ARIA role of 'row' if they can receive focus

Compute accessible name of objects with ARIA role of 'row' if they can receive focus

BUG=710024
Review-Url: https://codereview.chromium.org/2805343002
Cr-Commit-Position: refs/heads/master@{#463365}
Committed: https://chromium.googlesource.com/chromium/src/+/0d185a4f7b041c7322802f7b667fcf912c1391c6

[aleventhal, 2017-04-07 19:27:40]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 19:28:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-04-07 20:10:21]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 20:11:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-04-07 21:19:23]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 21:19:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-04-07 21:19:50]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 21:20:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-04-07 21:37:29]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 21:37:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 23:20:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 23:20:11]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-04-10 16:32:11]

dmazzoni@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[dmazzoni, 2017-04-10 16:32:12]

Please associate this with a bug. It can be brief/concise but
a link to the spec might be nice

https://codereview.chromium.org/2805343002/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/accessibility/aria-row-name.html (right):

https://codereview.chromium.org/2805343002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/accessibility/aria-row-name.html:29:
test(function(t) {
It's probably good to have a negative test, too - i.e. a treegrid that's
not focusable and with no activedescendant does not give a name to
a row.

You could add a comment that we do this for performance reasons
even though technically the spec says to give it a name

[aleventhal, 2017-04-10 16:51:32]

Description was changed from

==========
Compute accessible name of objects with ARIA role of 'row' if they can receive
focus

BUG=None
==========

to

==========
Compute accessible name of objects with ARIA role of 'row' if they can receive
focus

BUG=710024
==========

[aleventhal, 2017-04-10 17:16:29]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 17:16:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-04-10 17:19:00]

Added negative test and bug.

https://codereview.chromium.org/2805343002/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/accessibility/aria-row-name.html (right):

https://codereview.chromium.org/2805343002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/accessibility/aria-row-name.html:29:
test(function(t) {
On 2017/04/10 16:32:12, dmazzoni wrote:
> It's probably good to have a negative test, too - i.e. a treegrid that's
> not focusable and with no activedescendant does not give a name to
> a row.
> 
> You could add a comment that we do this for performance reasons
> even though technically the spec says to give it a name

Done.

[dmazzoni, 2017-04-10 17:27:04]

lgtm

Thanks!

[commit-bot: I haz the power, 2017-04-10 18:39:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 18:39:11]

Dry run: This issue passed the CQ dry run.

[aleventhal, 2017-04-10 19:25:18]

The CQ bit was checked by aleventhal@chromium.org

[commit-bot: I haz the power, 2017-04-10 19:26:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 19:38:23]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1491852318434530,
"parent_rev": "b9af474c03151485e6fc051804996b996371bc94", "commit_rev":
"0d185a4f7b041c7322802f7b667fcf912c1391c6"}

[commit-bot: I haz the power, 2017-04-10 19:39:14]

Description was changed from

==========
Compute accessible name of objects with ARIA role of 'row' if they can receive
focus

BUG=710024
==========

to

==========
Compute accessible name of objects with ARIA role of 'row' if they can receive
focus

BUG=710024

Review-Url: https://codereview.chromium.org/2805343002
Cr-Commit-Position: refs/heads/master@{#463365}
Committed:
https://chromium.googlesource.com/chromium/src/+/0d185a4f7b041c7322802f7b667f...
==========

[commit-bot: I haz the power, 2017-04-10 19:39:15]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/0d185a4f7b041c7322802f7b667f...