Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2805333002: Move ScriptState::getExecutionContext (Part 1) (Closed)

Created:
3 years, 8 months ago by adithyas
Modified:
3 years, 8 months ago
Reviewers:
haraken, jbroman
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ScriptState::getExecutionContext (Part 1) This CL adds ExecutionContext::from(ScriptState*) to eventually replace ScriptState::getExecutionContext. This is to remove a dependency to ExecutionContext from ScriptState. BUG=682322 Review-Url: https://codereview.chromium.org/2805333002 Cr-Commit-Position: refs/heads/master@{#463323} Committed: https://chromium.googlesource.com/chromium/src/+/a2c9e7f48dd30dbc7a2a4c6112414b6c1dd154c1

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptState.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptState.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
adithyas
3 years, 8 months ago (2017-04-07 21:33:16 UTC) #6
haraken
LGTM
3 years, 8 months ago (2017-04-07 22:40:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805333002/20001
3 years, 8 months ago (2017-04-10 15:18:19 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 18:07:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a2c9e7f48dd30dbc7a2a4c611241...

Powered by Google App Engine
This is Rietveld 408576698