Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2805323003: Revert "Ensure initial focus is set properly when creating a ContentViewCore" (Closed)

Created:
3 years, 8 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 8 months ago
Reviewers:
mthiesse
CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Ensure initial focus is set properly when creating a ContentViewCore" Also revert dependent patch: Revert "Fix crash in ContentViewCore#onResolveTapDisambiguation due to null ContainerView" This patch introduced null pointer crashes. NOTRY=true TBR=mthiesse@chromium.org BUG=709361, 708733 Review-Url: https://codereview.chromium.org/2805323003 Cr-Commit-Position: refs/heads/master@{#463088} Committed: https://chromium.googlesource.com/chromium/src/+/7a4822cef0d01331ae273a70752341b45f654802

Patch Set 1 #

Patch Set 2 : Clean revert since http://crrev.com/462419 also reverted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 6 chunks +10 lines, -13 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 1 1 chunk +4 lines, -4 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805323003/20001
3 years, 8 months ago (2017-04-08 00:11:21 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-08 01:04:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7a4822cef0d01331ae273a707523...

Powered by Google App Engine
This is Rietveld 408576698