Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2805283003:
Inline algorithm should take into account the wrapper's clearance line. (Closed)
|
Created:
3 years, 8 months ago by Gleb Lanbin Modified:
3 years, 8 months ago CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionInline algorithm should take into account the wrapper's clearance line.
Inline block's clearance is ignored unlike the wrapper's clearance line
that should be take into account when InlineLayoutAlgorithm updates
fragment's BFC offset.
BUG=635619
TEST=virtual/layout_ng/fast/block/margin-collapse/webkit-margin-collapse-floats.html
Review-Url: https://codereview.chromium.org/2805283003
Cr-Commit-Position: refs/heads/master@{#464008}
Committed: https://chromium.googlesource.com/chromium/src/+/84ebc90d051758718f7caa2dd32d507678c6f00f
Patch Set 1 #Patch Set 2 : remove confusing comment #Patch Set 3 : git rebase-update #
Messages
Total messages: 47 (34 generated)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by glebl@chromium.org to run a CQ dry run
glebl@chromium.org changed reviewers: + ikilpatrick@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
glebl@chromium.org changed reviewers: + cbiesinger@chromium.org
lgtm
Description was changed from ========== Inline algorithm should take into account the wrapper's clearance line. Inline block's clearance is ignored unlike the wrapper's clearance line that should be take into account when InlineLayoutAlgorithm updates fragment's BFC offset. BUG=635619 TEST=virtual/layout_ng/fast/block/margin-collapse/webkit-margin-collapse-floats.html ========== to ========== Inline algorithm should take into account the wrapper's clearance line. Inline block's clearance is ignored unlike the wrapper's clearance line that should be take into account when InlineLayoutAlgorithm updates fragment's BFC offset. BUG=635619 TEST=virtual/layout_ng/fast/block/margin-collapse/webkit-margin-collapse-floats.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ==========
The CQ bit was checked by glebl@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
The CQ bit was checked by glebl@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ikilpatrick@chromium.org Link to the patchset: https://codereview.chromium.org/2805283003/#ps40001 (title: "remove confusing comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
The CQ bit was checked by glebl@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
The CQ bit was checked by glebl@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ikilpatrick@chromium.org Link to the patchset: https://codereview.chromium.org/2805283003/#ps60001 (title: "git rebase-update")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
The CQ bit was checked by glebl@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
The CQ bit was checked by glebl@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
The CQ bit was checked by glebl@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_layout_tests_layout_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)
Description was changed from ========== Inline algorithm should take into account the wrapper's clearance line. Inline block's clearance is ignored unlike the wrapper's clearance line that should be take into account when InlineLayoutAlgorithm updates fragment's BFC offset. BUG=635619 TEST=virtual/layout_ng/fast/block/margin-collapse/webkit-margin-collapse-floats.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng ========== to ========== Inline algorithm should take into account the wrapper's clearance line. Inline block's clearance is ignored unlike the wrapper's clearance line that should be take into account when InlineLayoutAlgorithm updates fragment's BFC offset. BUG=635619 TEST=virtual/layout_ng/fast/block/margin-collapse/webkit-margin-collapse-floats.html ==========
The CQ bit was checked by glebl@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492003066891510,
"parent_rev": "82dacd2fe4b344aef399c25f0f186f435bac888d", "commit_rev":
"84ebc90d051758718f7caa2dd32d507678c6f00f"}
Message was sent while issue was closed.
Description was changed from ========== Inline algorithm should take into account the wrapper's clearance line. Inline block's clearance is ignored unlike the wrapper's clearance line that should be take into account when InlineLayoutAlgorithm updates fragment's BFC offset. BUG=635619 TEST=virtual/layout_ng/fast/block/margin-collapse/webkit-margin-collapse-floats.html ========== to ========== Inline algorithm should take into account the wrapper's clearance line. Inline block's clearance is ignored unlike the wrapper's clearance line that should be take into account when InlineLayoutAlgorithm updates fragment's BFC offset. BUG=635619 TEST=virtual/layout_ng/fast/block/margin-collapse/webkit-margin-collapse-floats.html Review-Url: https://codereview.chromium.org/2805283003 Cr-Commit-Position: refs/heads/master@{#464008} Committed: https://chromium.googlesource.com/chromium/src/+/84ebc90d051758718f7caa2dd32d... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/84ebc90d051758718f7caa2dd32d... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
