Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2805213002: Fix extension->id() nullptr access at TabCaptureAccessHandler::HandleRequest (Closed)

Created:
3 years, 8 months ago by pavor
Modified:
3 years, 8 months ago
CC:
chromium-reviews, chfremer+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix extension->id() nullptr access at TabCaptureAccessHandler::HandleRequest There is a check for null pointer of |extension| parameter, but it is then accessed via a call extension->id(). R=changbin.shao, dcheng BUG=709421 Review-Url: https://codereview.chromium.org/2805213002 Cr-Commit-Position: refs/heads/master@{#463209} Committed: https://chromium.googlesource.com/chromium/src/+/5d7042a87c4f1901ef1ed03d29f3e31e8af1724d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/media/webrtc/tab_capture_access_handler.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
pavor
3 years, 8 months ago (2017-04-07 11:42:37 UTC) #1
dcheng
LGTM, but I am not an OWNER. +sergeyu
3 years, 8 months ago (2017-04-07 17:26:38 UTC) #3
Sergey Ulanov
lgtm
3 years, 8 months ago (2017-04-07 18:06:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805213002/1
3 years, 8 months ago (2017-04-10 09:59:23 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 10:04:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5d7042a87c4f1901ef1ed03d29f3...

Powered by Google App Engine
This is Rietveld 408576698