Chromium Code Reviews

Issue 2805203003: Avoid converting an IntRect to IntRect via FloatRect (Closed)

Created:
3 years, 8 months ago by Daniel Bratell
Modified:
3 years, 8 months ago
Reviewers:
mstensho (USE GERRIT)
CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, blink-reviews-layout_chromium.org, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid converting an IntRect to IntRect via FloatRect IntRects can be implictly converted to FloatRect so code managed to call enclosingIntRect on an IntRect which then converted to FloatRect and back for an expensive noop. R=mstensho@opera.com CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2805203003 Cr-Commit-Position: refs/heads/master@{#462848} Committed: https://chromium.googlesource.com/chromium/src/+/42cd1de28a6495c29e355dd4114f83ebb74a71bd

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+1 line, -1 line)
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 8 (4 generated)
Daniel Bratell
3 years, 8 months ago (2017-04-07 12:03:19 UTC) #1
mstensho (USE GERRIT)
lgtm
3 years, 8 months ago (2017-04-07 12:06:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805203003/1
3 years, 8 months ago (2017-04-07 12:06:52 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 13:37:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/42cd1de28a6495c29e355dd4114f...

Powered by Google App Engine