Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2805203002: Un-skipped wpt/csp/svg tests (Closed)

Created:
3 years, 8 months ago by andypaicu
Modified:
3 years, 8 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Un-skipped wpt/csp/svg tests Moved and adapted existing svg test into wpt Existing tests work BUG=694525 Review-Url: https://codereview.chromium.org/2805203002 Cr-Commit-Position: refs/heads/master@{#463212} Committed: https://chromium.googlesource.com/chromium/src/+/3317e61588169b796f87ded214021d2950ca0de6

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed loaded object #

Messages

Total messages: 18 (12 generated)
andypaicu
3 years, 8 months ago (2017-04-07 10:36:44 UTC) #4
Mike West
This is only going to work for Blink. Would you mind making it a little ...
3 years, 8 months ago (2017-04-07 16:01:00 UTC) #7
andypaicu
https://codereview.chromium.org/2805203002/diff/1/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/support/mock-plugin.pl File third_party/WebKit/LayoutTests/external/wpt/content-security-policy/support/mock-plugin.pl (right): https://codereview.chromium.org/2805203002/diff/1/third_party/WebKit/LayoutTests/external/wpt/content-security-policy/support/mock-plugin.pl#newcode5 third_party/WebKit/LayoutTests/external/wpt/content-security-policy/support/mock-plugin.pl:5: print "This is a mock plugin. It does pretty ...
3 years, 8 months ago (2017-04-10 08:17:48 UTC) #10
Mike West
LGTM, thanks!
3 years, 8 months ago (2017-04-10 10:10:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805203002/20001
3 years, 8 months ago (2017-04-10 10:21:20 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 10:27:35 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3317e61588169b796f87ded21402...

Powered by Google App Engine
This is Rietveld 408576698