Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2805173002: Add video pixel tests for DirectComposition layers. (Closed)

Created:
3 years, 8 months ago by jbauman
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add video pixel tests for DirectComposition layers. The --enable-direct-composition-layers flag will force chrome to use DirectComposition layers for hardware-decoded video (assuming DirectComposition is actually supported on the system). BUG=704389 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2805173002 Cr-Commit-Position: refs/heads/master@{#463008} Committed: https://chromium.googlesource.com/chromium/src/+/67e8bdf6ec24a9c345a6978a65338c7497cb4f59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_integration_test.py View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_test_pages.py View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
jbauman
3 years, 8 months ago (2017-04-07 10:32:30 UTC) #7
Ken Russell (switch to Gerrit)
lgtm Is the pixel snapshot mechanism working sufficiently well for DirectComposition at this point?
3 years, 8 months ago (2017-04-07 19:11:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805173002/1
3 years, 8 months ago (2017-04-07 20:33:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/67e8bdf6ec24a9c345a6978a65338c7497cb4f59
3 years, 8 months ago (2017-04-07 21:36:03 UTC) #13
jbauman
3 years, 8 months ago (2017-04-07 22:52:20 UTC) #14
Message was sent while issue was closed.
On 2017/04/07 19:11:28, Ken Russell wrote:
> lgtm
> 
> Is the pixel snapshot mechanism working sufficiently well for
DirectComposition
> at this point?

Yeah, it seems to be working pretty well. It's certainly good enough for normal
presentation without overlays, which uses a very simple DirectComposition layer
tree already.

Powered by Google App Engine
This is Rietveld 408576698