Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2805133006: Requiring Get prefix for 2 more methods (to avoid conflicts after Blink rename). (Closed)

Created:
3 years, 8 months ago by Łukasz Anforowicz
Modified:
3 years, 8 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Requiring Get prefix for 2 more methods (to avoid conflicts after Blink rename). This CL adds a few more methods that cause name collisions when Blink is rewritten to match Chromium style: - dragOperation - locationInBackingMap BUG=582312 TBR=dcheng@chromium.org Review-Url: https://codereview.chromium.org/2805133006 Cr-Commit-Position: refs/heads/master@{#463039} Committed: https://chromium.googlesource.com/chromium/src/+/3f4f524dcb8700e6df122af9acc56ba86981d16c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805133006/1
3 years, 8 months ago (2017-04-07 22:07:18 UTC) #2
Łukasz Anforowicz
dcheng@ - I am TBR-ing adding 2 more methods that need a "Get" prefix. PS. ...
3 years, 8 months ago (2017-04-07 22:07:47 UTC) #3
dcheng
LGTM
3 years, 8 months ago (2017-04-07 22:19:02 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 23:14:49 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3f4f524dcb8700e6df122af9acc5...

Powered by Google App Engine
This is Rietveld 408576698