Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 2805113002: [CrOS Tether] Make BluetoothThrottler a singleton which can be easily shared between EasyUnlock and… (Closed)

Created:
3 years, 8 months ago by Kyle Horimoto
Modified:
3 years, 8 months ago
Reviewers:
Tim Song
CC:
chromium-reviews, extensions-reviews_chromium.org, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, chromium-apps-reviews_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CrOS Tether] Make BluetoothThrottler a singleton which can be easily shared between EasyUnlock and tethering. BUG=672263 Review-Url: https://codereview.chromium.org/2805113002 Cr-Commit-Position: refs/heads/master@{#462747} Committed: https://chromium.googlesource.com/chromium/src/+/1dedf46ece745194dd618cbedc84f402acf53d6e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -18 lines) Patch
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M components/cryptauth/bluetooth_throttler_impl.h View 3 chunks +10 lines, -3 lines 1 comment Download
M components/cryptauth/bluetooth_throttler_impl.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M components/proximity_auth/remote_device_life_cycle_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/proximity_auth/remote_device_life_cycle_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Kyle Horimoto
3 years, 8 months ago (2017-04-06 20:58:12 UTC) #2
Kyle Horimoto
3 years, 8 months ago (2017-04-06 20:59:03 UTC) #4
Tim Song
https://codereview.chromium.org/2805113002/diff/1/components/cryptauth/bluetooth_throttler_impl.h File components/cryptauth/bluetooth_throttler_impl.h (right): https://codereview.chromium.org/2805113002/diff/1/components/cryptauth/bluetooth_throttler_impl.h#newcode32 components/cryptauth/bluetooth_throttler_impl.h:32: static BluetoothThrottlerImpl* GetInstance(); I would put this singleton getter ...
3 years, 8 months ago (2017-04-06 23:38:12 UTC) #5
Tim Song
As discussed offline, it's better to leave the singleton in the impl file. LGTM
3 years, 8 months ago (2017-04-07 00:43:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805113002/1
3 years, 8 months ago (2017-04-07 00:46:05 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 04:42:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1dedf46ece745194dd618cbedc84...

Powered by Google App Engine
This is Rietveld 408576698