Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2805083002: Reland Change app icon to @drawable/ic_launcher (Closed)

Created:
3 years, 8 months ago by Theresa
Modified:
3 years, 8 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland Change app icon to @drawable/ic_launcher This reverts commit f7080b8d0e906ba0a0bb13411597645233a56a99. On channel builds of Chrome, the PackageManager was failing to find @mipmap/ic_launcher, but it has no trouble finding @drawable/ic_launcher. A new values/ic_launcher_alias.xml create an alias from @drawable/ic_launcher to the old @mipmap/app_icon. drawable-v26/ic_launcher.xml provides an @drawable/ic_launcher version for adaptive icons. BUG=707449 Review-Url: https://codereview.chromium.org/2805083002 Cr-Commit-Position: refs/heads/master@{#462660} Committed: https://chromium.googlesource.com/chromium/src/+/b8456f4c1ab4122fc65d85b973a39637b9ad2146

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/android/java/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
A chrome/android/java/res/values/ic_launcher_alias.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Theresa
ptal
3 years, 8 months ago (2017-04-06 19:21:57 UTC) #4
Ted C
lgtm
3 years, 8 months ago (2017-04-06 20:12:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805083002/1
3 years, 8 months ago (2017-04-06 20:14:05 UTC) #9
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 8 months ago (2017-04-06 20:40:22 UTC) #12
Theresa
On 2017/04/06 20:40:22, commit-bot: I haz the power wrote: > Prior attempt to commit was ...
3 years, 8 months ago (2017-04-06 22:10:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805083002/1
3 years, 8 months ago (2017-04-06 22:11:07 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 22:44:50 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b8456f4c1ab4122fc65d85b973a3...

Powered by Google App Engine
This is Rietveld 408576698