Add a GetAlternativeService method to HttpStream to return any

Add a GetAlternativeService method to HttpStream to return any
alternative service used for this stream.

Review-Url: https://codereview.chromium.org/2805043004
Cr-Commit-Position: refs/heads/master@{#464163}
Committed: https://chromium.googlesource.com/chromium/src/+/cd379013f1e038acf07952967270338cb459f8a9

[Ryan Hamilton, 2017-04-07 18:37:36]

rch@chromium.org changed reviewers:
+ bnc@chromium.org

[Ryan Hamilton, 2017-04-07 18:37:36]

I'm going to use this new method up in HttpNetworkTransaction in order to mark
QUIC broken under some new circumstances (in conjunction with retry using your
new enable_alternative_services_ = false).

[Bence, 2017-04-10 13:37:57]

LGTM with one nit.  Thank you.

https://codereview.chromium.org/2805043004/diff/1/net/quic/chromium/quic_http...
File net/quic/chromium/quic_http_stream_test.cc (right):

https://codereview.chromium.org/2805043004/diff/1/net/quic/chromium/quic_http...
net/quic/chromium/quic_http_stream_test.cc:365: request_headers_ =
client_maker_.GetRequestHeaders(method, "https", path);
Woo-hoo!  Since QUIC requires https in production, this correction was probably
long overdue.

https://codereview.chromium.org/2805043004/diff/1/net/quic/chromium/quic_http...
net/quic/chromium/quic_http_stream_test.cc:998: <<
alternative_service.ToString();
Please remove this line: I'm making it unnecessary in
https://crrev.com/2808843002.

[Ryan Hamilton, 2017-04-12 19:44:12]

Thanks!

https://codereview.chromium.org/2805043004/diff/1/net/quic/chromium/quic_http...
File net/quic/chromium/quic_http_stream_test.cc (right):

https://codereview.chromium.org/2805043004/diff/1/net/quic/chromium/quic_http...
net/quic/chromium/quic_http_stream_test.cc:998: <<
alternative_service.ToString();
On 2017/04/10 13:37:57, Bence wrote:
> Please remove this line: I'm making it unnecessary in
> https://crrev.com/2808843002.

Done.

[Ryan Hamilton, 2017-04-12 19:44:19]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2017-04-12 19:44:20]

The patchset sent to the CQ was uploaded after l-g-t-m from bnc@chromium.org
Link to the patchset: https://codereview.chromium.org/2805043004/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2017-04-12 19:45:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 21:53:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492026259637930,
"parent_rev": "507756d8e487854f780f5ee37962231491cee852", "commit_rev":
"cd379013f1e038acf07952967270338cb459f8a9"}

[commit-bot: I haz the power, 2017-04-12 21:58:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492026259637930,
"parent_rev": "507756d8e487854f780f5ee37962231491cee852", "commit_rev":
"cd379013f1e038acf07952967270338cb459f8a9"}

[commit-bot: I haz the power, 2017-04-12 21:58:49]

Description was changed from

==========
Add a GetAlternativeService method to HttpStream to return any
alternative service used for this stream.
==========

to

==========
Add a GetAlternativeService method to HttpStream to return any
alternative service used for this stream.

Review-Url: https://codereview.chromium.org/2805043004
Cr-Commit-Position: refs/heads/master@{#464163}
Committed:
https://chromium.googlesource.com/chromium/src/+/cd379013f1e038acf07952967270...
==========

[commit-bot: I haz the power, 2017-04-12 21:58:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/cd379013f1e038acf07952967270...