Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2805043002: Revert "Neuter the "screen scale factor" computation for SVG <text>" (Closed)

Created:
3 years, 8 months ago by fs
Modified:
3 years, 8 months ago
Reviewers:
Stephen Chennney
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, fmalita+watch_chromium.org, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, mac-reviews_chromium.org, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Neuter the "screen scale factor" computation for SVG <text>" This reverts commit 6f80957a6a5e7ec792a2f3cd7f06e2a744196d1d. Clean revert, but a reference to FrameHost had to be changed to Page, and an ASSERT was changed to a DCHECK. BUG=706880, 664961 Review-Url: https://codereview.chromium.org/2805043002 Cr-Commit-Position: refs/heads/master@{#462563} Committed: https://chromium.googlesource.com/chromium/src/+/7c6520814282912a6c6437e0c68537e11d77a9b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/platform/mac/svg/custom/masking-clipping-hidpi-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 3 chunks +39 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
fs
Fixes the regression on Android (or well, devtools emulation at least...) Baselines may need to ...
3 years, 8 months ago (2017-04-06 15:33:57 UTC) #5
Stephen Chennney
lgtm. Thanks.
3 years, 8 months ago (2017-04-06 15:45:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805043002/1
3 years, 8 months ago (2017-04-06 16:49:21 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 18:53:24 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7c6520814282912a6c6437e0c685...

Powered by Google App Engine
This is Rietveld 408576698