Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2805013003: Move MediaControlsMediaEventListener to modules/media_controls/. (Closed)

Created:
3 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 8 months ago
Reviewers:
haraken, whywhat
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, Srirama
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move MediaControlsMediaEventListener to modules/media_controls/. BUG=662761 R=avayvod@chromium.org,haraken@chromium.org Review-Url: https://codereview.chromium.org/2805013003 Cr-Commit-Position: refs/heads/master@{#463248} Committed: https://chromium.googlesource.com/chromium/src/+/e98522ee9fdfac2dde0cc806466f14d87258555f

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase after blink renaming #

Messages

Total messages: 19 (14 generated)
mlamouri (slow - plz ping)
rbyers@, please rubberstamp core/HTML/BUILD.gn avayvod@, please review the CL :)
3 years, 8 months ago (2017-04-06 22:36:11 UTC) #1
haraken
gn LGTM
3 years, 8 months ago (2017-04-07 01:58:29 UTC) #2
whywhat
lgtm
3 years, 8 months ago (2017-04-07 20:14:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805013003/40001
3 years, 8 months ago (2017-04-10 13:44:58 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 13:51:04 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e98522ee9fdfac2dde0cc806466f...

Powered by Google App Engine
This is Rietveld 408576698