MD Settings: Move Activity Controls link to Sync subpage

MD Settings: Move Activity Controls link to Sync subpage

Moves the Activity Controls link, (a.k.a. the sWAA link) from the
top-level People section to the Advanced Sync Settings subpage.

BUG=709111
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2805003005
Cr-Commit-Position: refs/heads/master@{#463061}
Committed: https://chromium.googlesource.com/chromium/src/+/41b9cfb8710fbeec6ead343de517cdb6fbd5d205

[tommycli, 2017-04-07 21:32:17]

Description was changed from

==========
MD Settings: Move Activity Controls link to Sync subpage

Moves the Activity Controls link, (a.k.a. the sWAA link) from the
top-level People section to the Advanced Sync Settings subpage.

BUG=709111
==========

to

==========
MD Settings: Move Activity Controls link to Sync subpage

Moves the Activity Controls link, (a.k.a. the sWAA link) from the
top-level People section to the Advanced Sync Settings subpage.

BUG=709111
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2017-04-07 21:32:22]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 21:33:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-04-07 22:19:11]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2017-04-07 22:19:11]

dbeam: PTAL

https://codereview.chromium.org/2805003005/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/people_page_test.js (left):

https://codereview.chromium.org/2805003005/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/people_page_test.js:332:
test('ActivityControlsLink', function() {
This test is no longer necessary, since the sync page that contains the new sWAA
link is not accessible unless signed in.

[Dan Beam, 2017-04-07 22:21:57]

lgtm

https://codereview.chromium.org/2805003005/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/people_page_test.js (left):

https://codereview.chromium.org/2805003005/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/people_page_test.js:332:
test('ActivityControlsLink', function() {
On 2017/04/07 22:19:11, tommycli wrote:
> This test is no longer necessary, since the sync page that contains the new
sWAA
> link is not accessible unless signed in.

Acknowledged.

[tommycli, 2017-04-07 22:47:02]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2017-04-07 22:47:07]

thanks for the review!

[commit-bot: I haz the power, 2017-04-07 22:47:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-08 00:00:44]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491605222775680,
"parent_rev": "f1587cef0bf3df927cd772454f6996e4492a6399", "commit_rev":
"41b9cfb8710fbeec6ead343de517cdb6fbd5d205"}

[commit-bot: I haz the power, 2017-04-08 00:01:34]

Description was changed from

==========
MD Settings: Move Activity Controls link to Sync subpage

Moves the Activity Controls link, (a.k.a. the sWAA link) from the
top-level People section to the Advanced Sync Settings subpage.

BUG=709111
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Move Activity Controls link to Sync subpage

Moves the Activity Controls link, (a.k.a. the sWAA link) from the
top-level People section to the Advanced Sync Settings subpage.

BUG=709111
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2805003005
Cr-Commit-Position: refs/heads/master@{#463061}
Committed:
https://chromium.googlesource.com/chromium/src/+/41b9cfb8710fbeec6ead343de517...
==========

[commit-bot: I haz the power, 2017-04-08 00:01:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/41b9cfb8710fbeec6ead343de517...