Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2805003002: Improve single_line spinner layout (Closed)

Created:
3 years, 8 months ago by dullweber
Modified:
3 years, 8 months ago
Reviewers:
Ted C, Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve single_line spinner ui - Align label to the right - Align arrow with checkboxes below - Increase top padding - change "Time period" to "Time range" before: https://screenshot.googleplex.com/P1hFk9v8V3k.png after: https://screenshot.googleplex.com/UrE3vtFdmy0.png BUG=681523 Review-Url: https://codereview.chromium.org/2805003002 Cr-Commit-Position: refs/heads/master@{#463192} Committed: https://chromium.googlesource.com/chromium/src/+/9f427ce4bfd95802a01ae0ac60e8a1b327f5ef53

Patch Set 1 #

Patch Set 2 : change "Time period" to "Time range" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M chrome/android/java/res/layout-sw360dp/preference_spinner_single_line.xml View 2 chunks +9 lines, -10 lines 0 comments Download
M chrome/android/java/res/layout/preference_spinner_single_line.xml View 2 chunks +1 line, -1 line 0 comments Download
M chrome/android/java/res/layout/preference_spinner_single_line_item.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
dullweber
twellington@chromium.org: Here is another small cl with layout tweaks. Thanks for reviewing all of this!
3 years, 8 months ago (2017-04-06 11:36:22 UTC) #3
Theresa
lgtm
3 years, 8 months ago (2017-04-06 15:09:10 UTC) #4
dullweber
tedchoc@chromium.org: Please review a change in chrome/android/java/strings/android_chrome_strings.grd for a string that was just added.
3 years, 8 months ago (2017-04-07 14:42:32 UTC) #6
Ted C
On 2017/04/07 14:42:32, dullweber wrote: > mailto:tedchoc@chromium.org: Please review a change in > chrome/android/java/strings/android_chrome_strings.grd for ...
3 years, 8 months ago (2017-04-07 17:02:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2805003002/20001
3 years, 8 months ago (2017-04-10 07:48:30 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 08:21:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9f427ce4bfd95802a01ae0ac60e8...

Powered by Google App Engine
This is Rietveld 408576698