Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2804963002: predictors: Put manifests for ResourcePrefetchPredictor behind a flag. (Closed)

Created:
3 years, 8 months ago by alexilin
Modified:
3 years, 8 months ago
Reviewers:
Benoit L
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Put manifests for ResourcePrefetchPredictor behind a flag. Add a flag to disable precache manifests usage in ResourcePrefetchPredictor by default. This flag is configurable through finch experement params. BUG=699115 Review-Url: https://codereview.chromium.org/2804963002 Cr-Commit-Position: refs/heads/master@{#463208} Committed: https://chromium.googlesource.com/chromium/src/+/8c484a3fff11a18c722b1690e1090effd1978a97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -5 lines) Patch
M chrome/browser/predictors/resource_prefetch_common.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_common.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_common_unittest.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
alexilin
PTAL, thanks!
3 years, 8 months ago (2017-04-06 11:18:00 UTC) #2
Benoit L
On 2017/04/06 11:18:00, alexilin wrote: > PTAL, thanks! lgtm
3 years, 8 months ago (2017-04-10 09:15:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804963002/1
3 years, 8 months ago (2017-04-10 09:19:36 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 10:03:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8c484a3fff11a18c722b1690e109...

Powered by Google App Engine
This is Rietveld 408576698