Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2804953008:
cc: Make surface aggregator convert surface quad to RPDQ correctly (Closed)
Descriptioncc: Make surface aggregator convert surface quad to RPDQ correctly
SurfaceAggregator used to arbitrarily set a place holder for
tex_coord_rect when converting surface quad to RPDQ.
This results in not applying any texture when effects are applied to the
whole surface. This patch corrects the value to be surface_quad->rect.
BUG=709369, 710040
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
Review-Url: https://codereview.chromium.org/2804953008
Cr-Commit-Position: refs/heads/master@{#463495}
Committed: https://chromium.googlesource.com/chromium/src/+/1ab7d98f69b14b75c21925564b099792ac13c2aa
Patch Set 1 #Patch Set 2 : Add unit test. #Patch Set 3 : Init expected tex_coord_rect. #Patch Set 4 : Revert "Add unit test." #
Messages
Total messages: 23 (14 generated)
Description was changed from ========== cc: Make surface aggregator convert surface quad to RPDQ correctly SurfaceAggregator used to arbitrarily set a place holder for tex_coord_rect when converting surface quad to RPDQ. This results in not applying any texture when effects are applied to the whole surface. This patch corrects the value to be surface_quad->rect. BUG= 709369 ========== to ========== cc: Make surface aggregator convert surface quad to RPDQ correctly SurfaceAggregator used to arbitrarily set a place holder for tex_coord_rect when converting surface quad to RPDQ. This results in not applying any texture when effects are applied to the whole surface. This patch corrects the value to be surface_quad->rect. BUG= 709369 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
The CQ bit was checked by sunxd@chromium.org to run a CQ dry run
Description was changed from ========== cc: Make surface aggregator convert surface quad to RPDQ correctly SurfaceAggregator used to arbitrarily set a place holder for tex_coord_rect when converting surface quad to RPDQ. This results in not applying any texture when effects are applied to the whole surface. This patch corrects the value to be surface_quad->rect. BUG= 709369 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== cc: Make surface aggregator convert surface quad to RPDQ correctly SurfaceAggregator used to arbitrarily set a place holder for tex_coord_rect when converting surface quad to RPDQ. This results in not applying any texture when effects are applied to the whole surface. This patch corrects the value to be surface_quad->rect. BUG= 709369 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
sunxd@chromium.org changed reviewers: + enne@chromium.org, trchen@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sunxd@chromium.org changed reviewers: + jbauman@chromium.org
PTAL.
lg tm, but I don't have enough expertise in this area of code.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
danakj@chromium.org changed reviewers: + danakj@chromium.org
Can has unit test?
I have added unit tests. However, the hard coded gfx::RectF(5,5) comes from https://cs.chromium.org/chromium/src/cc/test/surface_aggregator_test_helpers..... I haven't come up with a good way to deal with this.
Description was changed from ========== cc: Make surface aggregator convert surface quad to RPDQ correctly SurfaceAggregator used to arbitrarily set a place holder for tex_coord_rect when converting surface quad to RPDQ. This results in not applying any texture when effects are applied to the whole surface. This patch corrects the value to be surface_quad->rect. BUG= 709369 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== cc: Make surface aggregator convert surface quad to RPDQ correctly SurfaceAggregator used to arbitrarily set a place holder for tex_coord_rect when converting surface quad to RPDQ. This results in not applying any texture when effects are applied to the whole surface. This patch corrects the value to be surface_quad->rect. BUG= 709369, 710040 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ==========
PTAL again. Need to land this to fix a P1 bug, maybe we can land the CL first and work on the tests later?
The CQ bit was checked by sunxd@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jbauman@chromium.org Link to the patchset: https://codereview.chromium.org/2804953008/#ps60001 (title: "Revert "Add unit test."")
I'll land the fix first, and work on unit tests later.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491871942596210,
"parent_rev": "385c5d07e57f7ae48f7b6f4eedb2b9850b75e47a", "commit_rev":
"1ab7d98f69b14b75c21925564b099792ac13c2aa"}
Message was sent while issue was closed.
Description was changed from ========== cc: Make surface aggregator convert surface quad to RPDQ correctly SurfaceAggregator used to arbitrarily set a place holder for tex_coord_rect when converting surface quad to RPDQ. This results in not applying any texture when effects are applied to the whole surface. This patch corrects the value to be surface_quad->rect. BUG= 709369, 710040 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel ========== to ========== cc: Make surface aggregator convert surface quad to RPDQ correctly SurfaceAggregator used to arbitrarily set a place holder for tex_coord_rect when converting surface quad to RPDQ. This results in not applying any texture when effects are applied to the whole surface. This patch corrects the value to be surface_quad->rect. BUG= 709369, 710040 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2804953008 Cr-Commit-Position: refs/heads/master@{#463495} Committed: https://chromium.googlesource.com/chromium/src/+/1ab7d98f69b14b75c21925564b09... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/1ab7d98f69b14b75c21925564b09... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
