Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2804953005: Remove unused KeyboardUI::Show (Closed)

Created:
3 years, 8 months ago by oka
Modified:
3 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused KeyboardUI::Show BUG=None TEST=try Review-Url: https://codereview.chromium.org/2804953005 Cr-Commit-Position: refs/heads/master@{#462786} Committed: https://chromium.googlesource.com/chromium/src/+/032b38dd1c857d5074281ea390520bc3c1536b33

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M ash/common/keyboard/keyboard_ui.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/common/keyboard/keyboard_ui.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/mus/keyboard_ui_mus.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/mus/keyboard_ui_mus.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
oka
PTAL.
3 years, 8 months ago (2017-04-07 01:44:51 UTC) #7
oshima
lgtm
3 years, 8 months ago (2017-04-07 04:08:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804953005/1
3 years, 8 months ago (2017-04-07 05:15:49 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 06:00:26 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/032b38dd1c857d5074281ea39052...

Powered by Google App Engine
This is Rietveld 408576698