Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2804953004: Migrate WTF::HashTable::add() to ::insert() (Closed)

Created:
3 years, 8 months ago by pilgrim_google
Modified:
3 years, 8 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
blink-reviews, chromium-reviews, kinuko+watch, jsbell
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::HashTable::add() to ::insert() As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2804953004 Cr-Commit-Position: refs/heads/master@{#462589} Committed: https://chromium.googlesource.com/chromium/src/+/d4c2a4ad76f09cc46957aa46f843d4e18b8b8624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -26 lines) Patch
M third_party/WebKit/Source/platform/wtf/HashMap.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/HashSet.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/HashTable.h View 4 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/LinkedHashSet.h View 5 chunks +11 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/ListHashSet.h View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
pilgrim_google
3 years, 8 months ago (2017-04-06 17:16:57 UTC) #2
haraken
LGTM
3 years, 8 months ago (2017-04-06 17:20:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804953004/1
3 years, 8 months ago (2017-04-06 17:26:34 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 19:45:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d4c2a4ad76f09cc46957aa46f843...

Powered by Google App Engine
This is Rietveld 408576698