Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2804943004: Disable LoggingTest.CheckStreamsAreLazy/Dcheck tests due to flakiness. (Closed)

Created:
3 years, 8 months ago by Łukasz Anforowicz
Modified:
3 years, 8 months ago
Reviewers:
danakj, Elly Fong-Jones
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org, Elly Fong-Jones, akalin
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable LoggingTest.CheckStreamsAreLazy/Dcheck tests due to flakiness. BUG=709067 TBR=danakj@chromium.org Review-Url: https://codereview.chromium.org/2804943004 Cr-Commit-Position: refs/heads/master@{#462569} Committed: https://chromium.googlesource.com/chromium/src/+/ae6770cfd397cc0bc1de10cd557ba1ff59e3bea8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M base/logging_unittest.cc View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Łukasz Anforowicz
danakj@, could you please stamp this CL for me? (just got back from paternity leave ...
3 years, 8 months ago (2017-04-06 17:29:06 UTC) #4
Elly Fong-Jones
lgtm
3 years, 8 months ago (2017-04-06 18:06:09 UTC) #8
Łukasz Anforowicz
On 2017/04/06 18:06:09, Elly Fong-Jones wrote: > lgtm Thanks. danakj@ - I'll go ahead and ...
3 years, 8 months ago (2017-04-06 18:07:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804943004/1
3 years, 8 months ago (2017-04-06 18:07:20 UTC) #11
danakj
Wow that's some disturbing tests to be flaky. LGTM
3 years, 8 months ago (2017-04-06 18:09:24 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 19:06:20 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae6770cfd397cc0bc1de10cd557b...

Powered by Google App Engine
This is Rietveld 408576698