Avoid duplicate functions/code in core/editing: endTag

Avoid duplicate functions/code in core/editing: endTag

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

elementCannotHaveEndTag is a utility function used in serializers
and since it is used in multiple places, and MarkupFormatter is
not a good place for it, let us put it in EditingUtilities.

BUG=708949
R=yosin@chromium.org

Review-Url: https://codereview.chromium.org/2804943002
Cr-Commit-Position: refs/heads/master@{#462994}
Committed: https://chromium.googlesource.com/chromium/src/+/a7159abf14936edb1b8782dc06253c1ff91b9000

[Daniel Bratell, 2017-04-06 07:44:07]

bratell@opera.com changed reviewers:
+ yosin@chromium.org

[Daniel Bratell, 2017-04-06 07:44:07]

Please take a look.

[yosin_UTC9, 2017-04-06 08:30:54]

lgtm

Could you file a http://crbug.com with type=Task to consolidate series of
patches and
add BUG= line?

Because of you work is very valuable on Chromium project, I would like to
highlight your work.

[yosin_UTC9, 2017-04-06 08:48:24]

On 2017/04/06 at 08:30:54, yosin_UTC9 wrote:
> lgtm
> 
> Could you file a http://crbug.com with type=Task to consolidate series of
patches and
> add BUG= line?
> 
> Because of you work is very valuable on Chromium project, I would like to
highlight your work.

Also, could you announce your effort to blink-dev@ or chromium-dev@ if you also
do unify build on other than blink?
It seems some people know but others don't know. People who watches review
requests are confusing.

Since there are no tools to detect name conflicts among files, but announcing to
ML may people aware your effort.

Thanks in advance!

[Daniel Bratell, 2017-04-06 09:15:40]

Description was changed from

==========
Avoid duplicate functions/code in core/editing: endTag

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

elementCannotHaveEndTag is a utility function used in serializers
and since it is used in multiple places, and MarkupFormatter is
not a good place for it, let us put it in EditingUtilities.
==========

to

==========
Avoid duplicate functions/code in core/editing: endTag

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

elementCannotHaveEndTag is a utility function used in serializers
and since it is used in multiple places, and MarkupFormatter is
not a good place for it, let us put it in EditingUtilities.

BUG=708949
R=yosin@chromium.org
==========

[Daniel Bratell, 2017-04-06 09:25:50]

On 2017/04/06 08:48:24, yosin_UTC9 wrote:
> On 2017/04/06 at 08:30:54, yosin_UTC9 wrote:
> > lgtm
> > 
> > Could you file a http://crbug.com with type=Task to consolidate series of
> patches and
> > add BUG= line?
> > 
> > Because of you work is very valuable on Chromium project, I would like to
> highlight your work.
> 
> Also, could you announce your effort to blink-dev@ or chromium-dev@ if you
also
> do unify build on other than blink?
> It seems some people know but others don't know. People who watches review
> requests are confusing.
> 
> Since there are no tools to detect name conflicts among files, but announcing
to
> ML may people aware your effort.
> 
> Thanks in advance!

I have sent a few reports to blink-dev about this experiment but I guess only
some remember them or read them.
https://groups.google.com/a/chromium.org/d/msg/blink-dev/X7BHlt40RDk/IGcGKBdZ...
I can send more. Maybe I should include something to make it memorable...

It's a bit tricky because there is nothing that is more bikeshed-friendly than
the name of things. When people are tired of thinking of big and hard problems,
discussing the perfect coding style or symbol name is a nice relaxation.
Unfortunately it doesn't make things happen very fast.

[yosin_UTC9, 2017-04-06 09:34:31]

On 2017/04/06 at 09:25:50, bratell wrote:
> On 2017/04/06 08:48:24, yosin_UTC9 wrote:
> > On 2017/04/06 at 08:30:54, yosin_UTC9 wrote:
> > > lgtm
> > > 
> > > Could you file a http://crbug.com with type=Task to consolidate series of
> > patches and
> > > add BUG= line?
> > > 
> > > Because of you work is very valuable on Chromium project, I would like to
> > highlight your work.
> > 
> > Also, could you announce your effort to blink-dev@ or chromium-dev@ if you
also
> > do unify build on other than blink?
> > It seems some people know but others don't know. People who watches review
> > requests are confusing.
> > 
> > Since there are no tools to detect name conflicts among files, but
announcing to
> > ML may people aware your effort.
> > 
> > Thanks in advance!
> 
> I have sent a few reports to blink-dev about this experiment but I guess only
some remember them or read them.
>
https://groups.google.com/a/chromium.org/d/msg/blink-dev/X7BHlt40RDk/IGcGKBdZ...
> I can send more. Maybe I should include something to make it memorable...
I read that and know your effort.
I recommend to use "PSA" in subject to get more attention.

> It's a bit tricky because there is nothing that is more bikeshed-friendly than
the name of things. When people are tired of thinking of big and hard problems,
discussing the perfect coding style or symbol name is a nice relaxation.
Unfortunately it doesn't make things happen very fast.

There are number of opinions and may be bikeshed. But, asking some tool idea is
free. If lucky, someone propose or write a tool. ;-)
BTW, I remember file names in Firefox are requested unique, not sure it is still
requirement now.

[Peter Kasting, 2017-04-06 10:03:35]

https://codereview.chromium.org/2804943002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/2804943002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:1841: return
!toHTMLElement(node).shouldSerializeEndTag();
Drive-by: Possibly clearer:

  return node.isHTMLElement() && !toHTMLElement(node).shouldSerializeEndTag();

[Daniel Bratell, 2017-04-07 19:16:09]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2017-04-07 19:17:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 20:42:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491592569039610, "parent_rev":
"ca04ccfe0a0ef5e4026897735b8ac0a9d92c81a0", "commit_rev":
"a7159abf14936edb1b8782dc06253c1ff91b9000"}

[commit-bot: I haz the power, 2017-04-07 20:42:55]

Description was changed from

==========
Avoid duplicate functions/code in core/editing: endTag

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

elementCannotHaveEndTag is a utility function used in serializers
and since it is used in multiple places, and MarkupFormatter is
not a good place for it, let us put it in EditingUtilities.

BUG=708949
R=yosin@chromium.org
==========

to

==========
Avoid duplicate functions/code in core/editing: endTag

While experimenting with unity builds I encountered a few duplicate
symbols and functions in core/editing. This patch renames, moves
and unifies them.

elementCannotHaveEndTag is a utility function used in serializers
and since it is used in multiple places, and MarkupFormatter is
not a good place for it, let us put it in EditingUtilities.

BUG=708949
R=yosin@chromium.org

Review-Url: https://codereview.chromium.org/2804943002
Cr-Commit-Position: refs/heads/master@{#462994}
Committed:
https://chromium.googlesource.com/chromium/src/+/a7159abf14936edb1b8782dc0625...
==========

[commit-bot: I haz the power, 2017-04-07 20:42:57]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a7159abf14936edb1b8782dc0625...