Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2804933002: Update the list of eng reviewer and pull them into a separate file (Closed)

Created:
1 year, 5 months ago by jochen (gone - plz use gerrit)
Modified:
1 year, 4 months ago
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the list of eng reviewer and pull them into a separate file Also use that list for top-level owners, not just third-party R=darin@chromium.org,ben@chromium.org BUG= Review-Url: https://codereview.chromium.org/2804933002 Cr-Commit-Position: refs/heads/master@{#470859} Committed: https://chromium.googlesource.com/chromium/src/+/a6e12ea8b088afa8c2135dcc3fa583bb4c5bc945

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
A ENG_REVIEW_OWNERS View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M OWNERS View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/extensions/component_extensions_whitelist/OWNERS View 1 2 1 chunk +1 line, -7 lines 0 comments Download
M third_party/OWNERS View 1 2 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Ben Goodger (Google)
lgtm
1 year, 4 months ago (2017-05-09 15:53:41 UTC) #1
jochen (gone - plz use gerrit)
1 year, 4 months ago (2017-05-11 05:03:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804933002/40001
1 year, 4 months ago (2017-05-11 05:04:04 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/451370) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
1 year, 4 months ago (2017-05-11 05:07:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804933002/40001
1 year, 4 months ago (2017-05-11 06:40:37 UTC) #8
commit-bot: I haz the power
1 year, 4 months ago (2017-05-11 07:15:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a6e12ea8b088afa8c2135dcc3fa5...

Powered by Google App Engine
This is Rietveld 408576698