Remove redundant code from Android context menu native.

Remove redundant code from Android context menu native.

The two methods that fetch the currently selected image can
be collapsed into one.

BUG=655359
Review-Url: https://codereview.chromium.org/2804913003
Cr-Commit-Position: refs/heads/master@{#462923}
Committed: https://chromium.googlesource.com/chromium/src/+/69a502c5882ab8d0ee5f6189fdbfdba30bc483ef

[Ted C, 2017-04-06 16:53:33]

tedchoc@chromium.org changed reviewers:
+ dtrainor@chromium.org, nyquist@chromium.org

[Ted C, 2017-04-06 16:53:33]

PTAL

dtrainor - chrome/
nyquist - base/

[nyquist, 2017-04-06 17:17:12]

base lgtm

[David Trainor- moved to gerrit, 2017-04-06 21:53:58]

lgtm % nit

https://codereview.chromium.org/2804913003/diff/1/chrome/browser/ui/android/c...
File chrome/browser/ui/android/context_menu_helper.cc (right):

https://codereview.chromium.org/2804913003/diff/1/chrome/browser/ui/android/c...
chrome/browser/ui/android/context_menu_helper.cc:174: void
ContextMenuHelper::OnRetrieveImage(
Can this just be an anonymous namespace helper method in this cc file?  Then can
you get rid of the weak_factory_?  It looked like it was only used for this
thumbnail stuff?

[Ted C, 2017-04-07 17:09:37]

https://codereview.chromium.org/2804913003/diff/1/chrome/browser/ui/android/c...
File chrome/browser/ui/android/context_menu_helper.cc (right):

https://codereview.chromium.org/2804913003/diff/1/chrome/browser/ui/android/c...
chrome/browser/ui/android/context_menu_helper.cc:174: void
ContextMenuHelper::OnRetrieveImage(
On 2017/04/06 21:53:57, David Trainor-ping if over 24h wrote:
> Can this just be an anonymous namespace helper method in this cc file?  Then
can
> you get rid of the weak_factory_?  It looked like it was only used for this
> thumbnail stuff?

Done.

[Ted C, 2017-04-07 17:09:40]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2017-04-07 17:09:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
nyquist@chromium.org, dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2804913003/#ps40001
(title: "Address dtrainor@ comments")

[commit-bot: I haz the power, 2017-04-07 17:10:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 18:11:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491584980851060,
"parent_rev": "e7bcfaf35f821b8d95dcd0b5e9b70be1116bc56a", "commit_rev":
"69a502c5882ab8d0ee5f6189fdbfdba30bc483ef"}

[commit-bot: I haz the power, 2017-04-07 18:12:32]

Description was changed from

==========
Remove redundant code from Android context menu native.

The two methods that fetch the currently selected image can
be collapsed into one.

BUG=655359
==========

to

==========
Remove redundant code from Android context menu native.

The two methods that fetch the currently selected image can
be collapsed into one.

BUG=655359

Review-Url: https://codereview.chromium.org/2804913003
Cr-Commit-Position: refs/heads/master@{#462923}
Committed:
https://chromium.googlesource.com/chromium/src/+/69a502c5882ab8d0ee5f6189fdbf...
==========

[commit-bot: I haz the power, 2017-04-07 18:12:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/69a502c5882ab8d0ee5f6189fdbf...