Revert of Remove begin/end subseq. display items, and store on PaintController instead.

Revert of Remove begin/end subseq. display items, and store on PaintController instead. (patchset #12 id:220001 of https://codereview.chromium.org/2793233002/ )

Reason for revert:
PaintControllerUnderInvalidationTest.LessDrawingInSubsequence is failing on many builders.

Error from WebKit Linux Trusty:
PaintControllerUnderInvalidationTest.LessDrawingInSubsequence (run #1):
[ RUN      ] PaintControllerUnderInvalidationTest.LessDrawingInSubsequence

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:834:: Death tests use fork(), which is unsafe particularly in a threaded context. For this test, Google Test detected 2 threads.
../../third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp:2331: Failure
Death test: testLessDrawingInSubsequence()
    Result: failed to die.
 Error msg:
[  DEATH   ] [11609:11609:0406/212249.088581:18118180277:ERROR:PaintController.cpp(827)] "(In cached subsequence of first)" under-invalidation: new subsequence wrong length
[  DEATH   ] [11609:11609:0406/212249.088701:18118180330:ERROR:PaintController.cpp(828)] Subsequence client: "first"
[  DEATH   ] [11609:11609:0406/212249.088713:18118180341:ERROR:PaintController.cpp(832)] Run debug build to get more details.
[  DEATH   ] [11609:11609:0406/212249.088718:18118180346:ERROR:PaintController.cpp(834)] See http://crbug.com/619103.
[  DEATH   ]
[  FAILED  ] PaintControllerUnderInvalidationTest.LessDrawingInSubsequence

Original issue's description:
> Remove begin/end subseq. display items, and store on PaintController instead.
> 
> Subsequence display items cause complications for the SPv2 compositing algorithm
> because they confuse the PaintChunker. Also, they are the last remaining
> paired display item in SPv2 that blocks simplifying the display list format.
> 
> BUG=692614
> 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2793233002
> Cr-Commit-Position: refs/heads/master@{#462735}
> Committed: https://chromium.googlesource.com/chromium/src/+/256619b40e56be177620efb04b57086b2f6bcbed

TBR=wangxianzhu@chromium.org,chrishtr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=692614

[foolip, 2017-04-07 05:12:52]

The CQ bit was checked by foolip@chromium.org

[foolip, 2017-04-07 05:12:52]

Created Revert of Remove begin/end subseq. display items, and store on
PaintController instead.

[commit-bot: I haz the power, 2017-04-07 05:13:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 05:42:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 05:42:25]

Failed to apply patch for
third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2:
While running git apply --index -3 -p1;
  error: patch failed:
third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2:1360
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error:
third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2: patch
does not apply

Patch:      
third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
Index: third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
diff --git
a/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
b/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
index
f5a5be41bd40e892a9746137b9ddc709129a171b..7e24bee27b785e5d12fc0e1e58c1d0aa089dadeb
100644
--- a/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
+++ b/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
@@ -110,7 +110,6 @@
 
 Bug(none) compositing/3d-cube.html [ Failure ]
 Bug(none) compositing/absolute-inside-out-of-view-fixed.html [ Failure ]
-Bug(none)
compositing/always-composite-fixed-position-when-descendants-composite.html [
Failure ]
 Bug(none) compositing/animation/hidden-composited.html [ Failure ]
 Bug(none) compositing/backface-visibility/backface-visibility-image.html [
Failure ]
 Bug(none) compositing/backface-visibility/backface-visibility-webgl.html [
Failure ]
@@ -1360,11 +1359,6 @@
 crbug.com/692310 virtual/threaded/transitions/opacity-transition-zindex.html [
Timeout ]
 crbug.com/692310 virtual/threaded/transitions/unprefixed-transform.html [
Timeout ]
 
-Bug(none) virtual/threaded/animations/3d/change-transform-in-end-event.html [
Failure ]
-Bug(none) virtual/threaded/animations/composited-pseudo-element-animation.html
[ Failure ]
-Bug(none)
virtual/threaded/animations/css-composite-animation-affects-use-elements.html [
Failure ]
-Bug(none) virtual/threaded/transitions/transition-end-event-rendering.html [
Failure ]
-
 # Compositor Worker logic has not yet been fully ported to SPv2.
 crbug.com/686897
virtual/threaded/fast/compositorworker/compositor-attribute-change-worker.html [
Timeout ]
 crbug.com/686897
virtual/threaded/fast/compositorworker/compositor-proxy-disconnect-worker.html [
Timeout ]

[foolip, 2017-04-07 07:40:04]

Description was changed from

==========
Revert of Remove begin/end subseq. display items, and store on PaintController
instead. (patchset #12 id:220001 of https://codereview.chromium.org/2793233002/
)

Reason for revert:
PaintControllerUnderInvalidationTest.LessDrawingInSubsequence is failing on many
builders.

Error from WebKit Linux Trusty:
PaintControllerUnderInvalidationTest.LessDrawingInSubsequence (run #1):
[ RUN      ] PaintControllerUnderInvalidationTest.LessDrawingInSubsequence

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:834:: Death tests use
fork(), which is unsafe particularly in a threaded context. For this test,
Google Test detected 2 threads.
../../third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp:2331:
Failure
Death test: testLessDrawingInSubsequence()
    Result: failed to die.
 Error msg:
[  DEATH   ]
[11609:11609:0406/212249.088581:18118180277:ERROR:PaintController.cpp(827)] "(In
cached subsequence of first)" under-invalidation: new subsequence wrong length
[  DEATH   ]
[11609:11609:0406/212249.088701:18118180330:ERROR:PaintController.cpp(828)]
Subsequence client: "first"
[  DEATH   ]
[11609:11609:0406/212249.088713:18118180341:ERROR:PaintController.cpp(832)] Run
debug build to get more details.
[  DEATH   ]
[11609:11609:0406/212249.088718:18118180346:ERROR:PaintController.cpp(834)] See
http://crbug.com/619103.
[  DEATH   ]
[  FAILED  ] PaintControllerUnderInvalidationTest.LessDrawingInSubsequence

Original issue's description:
> Remove begin/end subseq. display items, and store on PaintController instead.
> 
> Subsequence display items cause complications for the SPv2 compositing
algorithm
> because they confuse the PaintChunker. Also, they are the last remaining
> paired display item in SPv2 that blocks simplifying the display list format.
> 
> BUG=692614
> 
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2793233002
> Cr-Commit-Position: refs/heads/master@{#462735}
> Committed:
https://chromium.googlesource.com/chromium/src/+/256619b40e56be177620efb04b57...

TBR=wangxianzhu@chromium.org,chrishtr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=692614
==========

to

==========
Revert of Remove begin/end subseq. display items, and store on PaintController
instead. (patchset #12 id:220001 of https://codereview.chromium.org/2793233002/
)

Reason for revert:
PaintControllerUnderInvalidationTest.LessDrawingInSubsequence is failing on many
builders.

Error from WebKit Linux Trusty:
PaintControllerUnderInvalidationTest.LessDrawingInSubsequence (run #1):
[ RUN      ] PaintControllerUnderInvalidationTest.LessDrawingInSubsequence

[WARNING] ../../testing/gtest/src/gtest-death-test.cc:834:: Death tests use
fork(), which is unsafe particularly in a threaded context. For this test,
Google Test detected 2 threads.
../../third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp:2331:
Failure
Death test: testLessDrawingInSubsequence()
    Result: failed to die.
 Error msg:
[  DEATH   ]
[11609:11609:0406/212249.088581:18118180277:ERROR:PaintController.cpp(827)] "(In
cached subsequence of first)" under-invalidation: new subsequence wrong length
[  DEATH   ]
[11609:11609:0406/212249.088701:18118180330:ERROR:PaintController.cpp(828)]
Subsequence client: "first"
[  DEATH   ]
[11609:11609:0406/212249.088713:18118180341:ERROR:PaintController.cpp(832)] Run
debug build to get more details.
[  DEATH   ]
[11609:11609:0406/212249.088718:18118180346:ERROR:PaintController.cpp(834)] See
http://crbug.com/619103.
[  DEATH   ]
[  FAILED  ] PaintControllerUnderInvalidationTest.LessDrawingInSubsequence

Original issue's description:
> Remove begin/end subseq. display items, and store on PaintController instead.
> 
> Subsequence display items cause complications for the SPv2 compositing
algorithm
> because they confuse the PaintChunker. Also, they are the last remaining
> paired display item in SPv2 that blocks simplifying the display list format.
> 
> BUG=692614
> 
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2793233002
> Cr-Commit-Position: refs/heads/master@{#462735}
> Committed:
https://chromium.googlesource.com/chromium/src/+/256619b40e56be177620efb04b57...

TBR=wangxianzhu@chromium.org,chrishtr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=692614
==========