third_party/WebKit/Source/platform/graphics/paint/PaintChunkTest.cpp - Issue 2804883006: Revert of Remove begin/end subseq. display items, and store on PaintController instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintChunkTest.cpp

Issue 2804883006: Revert of Remove begin/end subseq. display items, and store on PaintController instead. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/PaintController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/PaintChunkTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintChunkTest.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintChunkTest.cpp

index a212dfb4bd868ed55e4050ec93cf4255a084a08a..7afd52cd7a0d98aa4a736ae2e2242a8fb951cd2c 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/PaintChunkTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintChunkTest.cpp

@@ -36,13 +36,20 @@

PaintChunkProperties properties;

FakeDisplayItemClient client1;

client1.updateCacheGeneration();

- DisplayItem::Id id1(client1, DisplayItem::kDrawingFirst);

+ DisplayItem::Id id1a(client1, DisplayItem::kDrawingFirst);

+ DisplayItem::Id id1b(client1, DisplayItem::kSubsequence);

+ EXPECT_FALSE(PaintChunk(0, 1, &id1a, properties)

+ .matches(PaintChunk(0, 1, &id1b, properties)));

+ EXPECT_FALSE(PaintChunk(0, 1, &id1b, properties)

+ .matches(PaintChunk(0, 1, &id1a, properties)));

FakeDisplayItemClient client2;

client2.updateCacheGeneration();

DisplayItem::Id id2(client2, DisplayItem::kDrawingFirst);

+ EXPECT_FALSE(PaintChunk(0, 1, &id1a, properties)

+ .matches(PaintChunk(0, 1, &id2, properties)));

EXPECT_FALSE(PaintChunk(0, 1, &id2, properties)

- .matches(PaintChunk(0, 1, &id1, properties)));

+ .matches(PaintChunk(0, 1, &id1a, properties)));

}

TEST(PaintChunkTest, IdNotMatchesNull) {