Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 2804753002: mus: Fix showing guest views in --mash and --mus. (Closed)

Created:
3 years, 8 months ago by sadrul
Modified:
3 years, 8 months ago
Reviewers:
Fady Samuel, jam, sky
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, sadrul, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Fix showing guest views in --mash and --mus. It is necessary to notify the RenderWidgetHostViewChildFrame of the surface associated with the child-frame, so that it can correctly notify the embedder. This fixes the login screen, opening pdf files in chrome, etc. BUG=694846 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2804753002 Cr-Commit-Position: refs/heads/master@{#463372} Committed: https://chromium.googlesource.com/chromium/src/+/1e0366fc5f961223c1862ff96a0bcd1302df32cd

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : tot merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M ui/aura/mus/window_port_mus.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M ui/aura/window_delegate.h View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (18 generated)
sadrul
This is still WIP (I want to clean up how WindowTreeClient sends the SurfaceInfo to ...
3 years, 8 months ago (2017-04-05 16:34:55 UTC) #3
Fady Samuel
this generally looks good so far.
3 years, 8 months ago (2017-04-06 04:04:17 UTC) #4
sadrul
+sky@ for review.
3 years, 8 months ago (2017-04-07 15:04:30 UTC) #11
sky
LGTM
3 years, 8 months ago (2017-04-07 19:09:58 UTC) #12
sadrul
+jam@ for content owner.
3 years, 8 months ago (2017-04-08 01:22:33 UTC) #17
jam
lgtm
3 years, 8 months ago (2017-04-10 14:54:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804753002/40001
3 years, 8 months ago (2017-04-10 17:53:07 UTC) #23
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 19:53:53 UTC) #26
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1e0366fc5f961223c1862ff96a0b...

Powered by Google App Engine
This is Rietveld 408576698