QUIC - fix crash bug in client handling of Server Push.

QUIC - fix crash bug in client handling of Server Push.

Fix crash bug for the case that a request with a body matches a
PUSH_PROMISE.

R=rch@chromium.org
BUG=705109
Review-Url: https://codereview.chromium.org/2804723003
Cr-Commit-Position: refs/heads/master@{#462659}
Committed: https://chromium.googlesource.com/chromium/src/+/dee375739b384173dea843b8f4e1632a4318d4d3

[Buck, 2017-04-05 23:15:29]

Description was changed from

==========
QUIC - fix crash bug in client handling of Server Push.

Fix crash bug for the case that a request with a body matches a
PUSH_PROMISE.

R=rch@chromium.org
BUG=
==========

to

==========
QUIC - fix crash bug in client handling of Server Push.

Fix crash bug for the case that a request with a body matches a
PUSH_PROMISE.

R=rch@chromium.org
BUG=705109
==========

[Buck, 2017-04-05 23:16:16]

The CQ bit was checked by ckrasic@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-05 23:16:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 00:53:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 00:53:25]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2017-04-06 19:46:48]

lgtm

https://codereview.chromium.org/2804723003/diff/1/net/quic/chromium/quic_http...
File net/quic/chromium/quic_http_stream.cc (right):

https://codereview.chromium.org/2804723003/diff/1/net/quic/chromium/quic_http...
net/quic/chromium/quic_http_stream.cc:311: next_state_ =
STATE_SET_REQUEST_PRIORITY;
nit: to reduce the nesting, can you do:

if (!found_promise_) {
  next_state_ = STATE_SET_REQUEST_PRIORITY;
} else if (!request_body_stream_) {
  next_state_ = STATE_HANDLE_PROMISE;
} else {
  found_promise_ = false;
  next_state_ = STATE_REQUEST_STREAM;
}

[Buck, 2017-04-06 19:59:55]

https://codereview.chromium.org/2804723003/diff/1/net/quic/chromium/quic_http...
File net/quic/chromium/quic_http_stream.cc (right):

https://codereview.chromium.org/2804723003/diff/1/net/quic/chromium/quic_http...
net/quic/chromium/quic_http_stream.cc:311: next_state_ =
STATE_SET_REQUEST_PRIORITY;
On 2017/04/06 19:46:48, Ryan Hamilton wrote:
> nit: to reduce the nesting, can you do:
> 
> if (!found_promise_) {
>   next_state_ = STATE_SET_REQUEST_PRIORITY;
> } else if (!request_body_stream_) {
>   next_state_ = STATE_HANDLE_PROMISE;
> } else {
>   found_promise_ = false;
>   next_state_ = STATE_REQUEST_STREAM;
> }

Done.

[Buck, 2017-04-06 19:59:59]

The CQ bit was checked by ckrasic@chromium.org

[Buck, 2017-04-06 20:00:00]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2804723003/#ps20001
(title: "review feedback + pull")

[commit-bot: I haz the power, 2017-04-06 20:01:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 22:42:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491508799796660,
"parent_rev": "2c0ca180a3b0db00edd152ed5b2a703942d84163", "commit_rev":
"dee375739b384173dea843b8f4e1632a4318d4d3"}

[commit-bot: I haz the power, 2017-04-06 22:43:17]

Description was changed from

==========
QUIC - fix crash bug in client handling of Server Push.

Fix crash bug for the case that a request with a body matches a
PUSH_PROMISE.

R=rch@chromium.org
BUG=705109
==========

to

==========
QUIC - fix crash bug in client handling of Server Push.

Fix crash bug for the case that a request with a body matches a
PUSH_PROMISE.

R=rch@chromium.org
BUG=705109

Review-Url: https://codereview.chromium.org/2804723003
Cr-Commit-Position: refs/heads/master@{#462659}
Committed:
https://chromium.googlesource.com/chromium/src/+/dee375739b384173dea843b8f4e1...
==========

[commit-bot: I haz the power, 2017-04-06 22:43:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dee375739b384173dea843b8f4e1...