Chromium Code Reviews
Help | Chromium Project | Sign in
(13)

Issue 2804703004: Use ScopedTaskEnvironment instead of MessageLoop in storage unit tests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks ago by fdoray
Modified:
2 weeks, 6 days ago
Reviewers:
kinuko, gab, nhiroki
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ScopedTaskEnvironment instead of MessageLoop in storage unit tests. ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and base/task_scheduler/post_task.h within its scope. It should be instantiated in every unit test that uses either of these APIs (i.e. no test should instantiate a MessageLoop directly). Motivation for ScopedTaskEnvironment can be found in: https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit BUG=708584 R=gab@chromium.org TBR=kinuko@chromium.org, nhiroki@chromium.org Review-Url: https://codereview.chromium.org/2804703004 Cr-Commit-Position: refs/heads/master@{#462491} Committed: https://chromium.googlesource.com/chromium/src/+/01875e5e4b2740eb0579d959ac8c28019583d61c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M storage/browser/database/database_quota_client_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M storage/browser/fileapi/quota/quota_backend_impl_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M storage/browser/fileapi/quota/quota_reservation_manager_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
fdoray
3 weeks ago (2017-04-05 19:48:58 UTC) #1
fdoray
gab@: PTAL The change will then be TBRed to the owner.
3 weeks ago (2017-04-05 19:49:00 UTC) #3
gab
lgtm
3 weeks ago (2017-04-05 20:55:32 UTC) #7
kinuko
lgtm
3 weeks ago (2017-04-06 01:39:53 UTC) #8
nhiroki
lgtm
3 weeks ago (2017-04-06 02:20:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804703004/1
2 weeks, 6 days ago (2017-04-06 15:28:15 UTC) #11
commit-bot: I haz the power
2 weeks, 6 days ago (2017-04-06 15:46:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/01875e5e4b2740eb0579d959ac8c...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cc6ac46