Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(399)

Issue 2804703004: Use ScopedTaskEnvironment instead of MessageLoop in storage unit tests. (Closed)

Created:
8 months, 1 week ago by fdoray
Modified:
8 months, 1 week ago
Reviewers:
kinuko, gab, nhiroki
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ScopedTaskEnvironment instead of MessageLoop in storage unit tests. ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and base/task_scheduler/post_task.h within its scope. It should be instantiated in every unit test that uses either of these APIs (i.e. no test should instantiate a MessageLoop directly). Motivation for ScopedTaskEnvironment can be found in: https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit BUG=708584 R=gab@chromium.org TBR=kinuko@chromium.org, nhiroki@chromium.org Review-Url: https://codereview.chromium.org/2804703004 Cr-Commit-Position: refs/heads/master@{#462491} Committed: https://chromium.googlesource.com/chromium/src/+/01875e5e4b2740eb0579d959ac8c28019583d61c

Patch Set 1 #

Messages

Total messages: 14 (7 generated)
fdoray
8 months, 1 week ago (2017-04-05 19:48:58 UTC) #1
fdoray
gab@: PTAL The change will then be TBRed to the owner.
8 months, 1 week ago (2017-04-05 19:49:00 UTC) #3
gab
lgtm
8 months, 1 week ago (2017-04-05 20:55:32 UTC) #7
kinuko
lgtm
8 months, 1 week ago (2017-04-06 01:39:53 UTC) #8
nhiroki
lgtm
8 months, 1 week ago (2017-04-06 02:20:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804703004/1
8 months, 1 week ago (2017-04-06 15:28:15 UTC) #11
commit-bot: I haz the power
8 months, 1 week ago (2017-04-06 15:46:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/01875e5e4b2740eb0579d959ac8c...

Powered by Google App Engine
This is Rietveld 0eb02b776