Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1205)

Unified Diff: content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc

Issue 2804693002: Remove coordinates from LatencyInfo objects. (Closed)
Patch Set: Fix fuzzer test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
diff --git a/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc b/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
index 701e40262672fb8eb22085ab287d68bf1af5771b..3522e797f56f8438ec6f3b036df37a9fc1175bf0 100644
--- a/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
+++ b/content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc
@@ -199,7 +199,6 @@ TEST_F(RenderWidgetHostLatencyTrackerTest, TestWheelToFirstScrollHistograms) {
tracker()->latency_component_id(), nullptr));
EXPECT_TRUE(wheel_latency.FindLatency(
ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 0, nullptr));
- EXPECT_EQ(1U, wheel_latency.input_coordinates_size());
tracker()->OnInputEventAck(wheel, &wheel_latency,
INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
tracker()->OnGpuSwapBuffersCompleted(wheel_latency);
@@ -291,7 +290,6 @@ TEST_F(RenderWidgetHostLatencyTrackerTest, TestWheelToScrollHistograms) {
tracker()->latency_component_id(), nullptr));
EXPECT_TRUE(wheel_latency.FindLatency(
ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 0, nullptr));
- EXPECT_EQ(1U, wheel_latency.input_coordinates_size());
tracker()->OnInputEventAck(wheel, &wheel_latency,
INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
tracker()->OnGpuSwapBuffersCompleted(wheel_latency);
@@ -367,7 +365,6 @@ TEST_F(RenderWidgetHostLatencyTrackerTest, TestTouchToFirstScrollHistograms) {
tracker()->latency_component_id(), nullptr));
EXPECT_TRUE(scroll_latency.FindLatency(
ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 0, nullptr));
- EXPECT_EQ(1U, scroll_latency.input_coordinates_size());
tracker()->OnInputEventAck(scroll, &scroll_latency,
INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
}
@@ -389,7 +386,6 @@ TEST_F(RenderWidgetHostLatencyTrackerTest, TestTouchToFirstScrollHistograms) {
tracker()->latency_component_id(), nullptr));
EXPECT_TRUE(touch_latency.FindLatency(
ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 0, nullptr));
- EXPECT_EQ(2U, touch_latency.input_coordinates_size());
tracker()->OnInputEventAck(touch, &touch_latency,
INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
tracker()->OnGpuSwapBuffersCompleted(touch_latency);
@@ -487,7 +483,6 @@ TEST_F(RenderWidgetHostLatencyTrackerTest, TestTouchToScrollHistograms) {
tracker()->latency_component_id(), nullptr));
EXPECT_TRUE(scroll_latency.FindLatency(
ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 0, nullptr));
- EXPECT_EQ(1U, scroll_latency.input_coordinates_size());
tracker()->OnInputEventAck(scroll, &scroll_latency,
INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
}
@@ -509,7 +504,6 @@ TEST_F(RenderWidgetHostLatencyTrackerTest, TestTouchToScrollHistograms) {
tracker()->latency_component_id(), nullptr));
EXPECT_TRUE(touch_latency.FindLatency(
ui::INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 0, nullptr));
- EXPECT_EQ(2U, touch_latency.input_coordinates_size());
tracker()->OnInputEventAck(touch, &touch_latency,
INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
tracker()->OnGpuSwapBuffersCompleted(touch_latency);
@@ -667,64 +661,6 @@ TEST_F(RenderWidgetHostLatencyTrackerTest,
EXPECT_TRUE(HistogramSizeEq("Event.Latency.ScrollUpdate.GpuSwap", 0));
}
-TEST_F(RenderWidgetHostLatencyTrackerTest, InputCoordinatesPopulated) {
- {
- auto event =
- SyntheticWebMouseWheelEventBuilder::Build(0, 0, -5, 0, 0, true);
- event.setPositionInWidget(100, 200);
- ui::LatencyInfo latency_info;
- tracker()->OnInputEvent(event, &latency_info);
- EXPECT_EQ(1u, latency_info.input_coordinates_size());
- EXPECT_EQ(100, latency_info.input_coordinates()[0].x());
- EXPECT_EQ(200, latency_info.input_coordinates()[0].y());
- }
-
- {
- auto event = SyntheticWebMouseEventBuilder::Build(WebInputEvent::MouseMove);
- event.setPositionInWidget(300, 400);
- ui::LatencyInfo latency_info;
- tracker()->OnInputEvent(event, &latency_info);
- EXPECT_EQ(1u, latency_info.input_coordinates_size());
- EXPECT_EQ(300, latency_info.input_coordinates()[0].x());
- EXPECT_EQ(400, latency_info.input_coordinates()[0].y());
- }
-
- {
- auto event = SyntheticWebGestureEventBuilder::Build(
- WebInputEvent::GestureScrollBegin, blink::WebGestureDeviceTouchscreen);
- event.x = 500;
- event.y = 600;
- ui::LatencyInfo latency_info;
- tracker()->OnInputEvent(event, &latency_info);
- EXPECT_EQ(1u, latency_info.input_coordinates_size());
- EXPECT_EQ(500, latency_info.input_coordinates()[0].x());
- EXPECT_EQ(600, latency_info.input_coordinates()[0].y());
- }
-
- {
- SyntheticWebTouchEvent event;
- event.PressPoint(700, 800);
- event.PressPoint(900, 1000);
- event.PressPoint(1100, 1200); // LatencyInfo only holds two coordinates.
- ui::LatencyInfo latency_info;
- tracker()->OnInputEvent(event, &latency_info);
- EXPECT_EQ(2u, latency_info.input_coordinates_size());
- EXPECT_EQ(700, latency_info.input_coordinates()[0].x());
- EXPECT_EQ(800, latency_info.input_coordinates()[0].y());
- EXPECT_EQ(900, latency_info.input_coordinates()[1].x());
- EXPECT_EQ(1000, latency_info.input_coordinates()[1].y());
- }
-
- {
- NativeWebKeyboardEvent event(blink::WebKeyboardEvent::KeyDown,
- blink::WebInputEvent::NoModifiers,
- base::TimeTicks::Now());
- ui::LatencyInfo latency_info;
- tracker()->OnInputEvent(event, &latency_info);
- EXPECT_EQ(0u, latency_info.input_coordinates_size());
- }
-}
-
TEST_F(RenderWidgetHostLatencyTrackerTest, ScrollLatency) {
auto scroll_begin = SyntheticWebGestureEventBuilder::BuildScrollBegin(
5, -5, blink::WebGestureDeviceTouchscreen);

Powered by Google App Engine
This is Rietveld 408576698