Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: content/browser/renderer_host/input/render_widget_host_latency_tracker.cc

Issue 2804693002: Remove coordinates from LatencyInfo objects. (Closed)
Patch Set: Fix fuzzer test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
diff --git a/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc b/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
index 625e8d371e5fe14b770404a1193e5dcdeed492c3..de37f5518da6832442e543a58869475a7aa35944 100644
--- a/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
+++ b/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
@@ -26,58 +26,6 @@ using ui::LatencyInfo;
namespace content {
namespace {
-void UpdateLatencyCoordinatesImpl(const blink::WebTouchEvent& touch,
- LatencyInfo* latency,
- float device_scale_factor) {
- for (uint32_t i = 0; i < touch.touchesLength; ++i) {
- gfx::PointF coordinate(touch.touches[i].position.x * device_scale_factor,
- touch.touches[i].position.y * device_scale_factor);
- if (!latency->AddInputCoordinate(coordinate))
- break;
- }
-}
-
-void UpdateLatencyCoordinatesImpl(const WebGestureEvent& gesture,
- LatencyInfo* latency,
- float device_scale_factor) {
- latency->AddInputCoordinate(gfx::PointF(gesture.x * device_scale_factor,
- gesture.y * device_scale_factor));
-}
-
-void UpdateLatencyCoordinatesImpl(const WebMouseEvent& mouse,
- LatencyInfo* latency,
- float device_scale_factor) {
- latency->AddInputCoordinate(
- gfx::PointF(mouse.positionInWidget().x * device_scale_factor,
- mouse.positionInWidget().y * device_scale_factor));
-}
-
-void UpdateLatencyCoordinatesImpl(const WebMouseWheelEvent& wheel,
- LatencyInfo* latency,
- float device_scale_factor) {
- latency->AddInputCoordinate(
- gfx::PointF(wheel.positionInWidget().x * device_scale_factor,
- wheel.positionInWidget().y * device_scale_factor));
-}
-
-void UpdateLatencyCoordinates(const WebInputEvent& event,
- float device_scale_factor,
- LatencyInfo* latency) {
- if (WebInputEvent::isMouseEventType(event.type())) {
- UpdateLatencyCoordinatesImpl(static_cast<const WebMouseEvent&>(event),
- latency, device_scale_factor);
- } else if (WebInputEvent::isGestureEventType(event.type())) {
- UpdateLatencyCoordinatesImpl(static_cast<const WebGestureEvent&>(event),
- latency, device_scale_factor);
- } else if (WebInputEvent::isTouchEventType(event.type())) {
- UpdateLatencyCoordinatesImpl(static_cast<const WebTouchEvent&>(event),
- latency, device_scale_factor);
- } else if (event.type() == WebInputEvent::MouseWheel) {
- UpdateLatencyCoordinatesImpl(static_cast<const WebMouseWheelEvent&>(event),
- latency, device_scale_factor);
- }
-}
-
// Check valid timing for start and end latency components.
#define CONFIRM_VALID_TIMING(start, end) \
DCHECK(!start.first_event_time.is_null()); \
@@ -470,8 +418,6 @@ void RenderWidgetHostLatencyTracker::OnInputEvent(
ui::INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT, latency_component_id_,
++last_event_id_, WebInputEvent::GetName(event.type()));
- UpdateLatencyCoordinates(event, device_scale_factor_, latency);
-
if (event.type() == blink::WebInputEvent::GestureScrollBegin) {
has_seen_first_gesture_scroll_update_ = false;
} else if (event.type() == blink::WebInputEvent::GestureScrollUpdate) {

Powered by Google App Engine
This is Rietveld 408576698