Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2804683002: Add UserAction documentation for MobileMenuDataSaverOpened (Closed)

Created:
3 years, 8 months ago by dgn
Modified:
3 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, Michael van Ouwerkerk, megjablon
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UserAction documentation for MobileMenuDataSaverOpened That was tripping the linter when other patches modify the action.xml file. The undocumented action was added in https://crrev.com/553df4cf074e9bb28abb303794af949730c6c77f BUG=702799 Review-Url: https://codereview.chromium.org/2804683002 Cr-Commit-Position: refs/heads/master@{#462081} Committed: https://chromium.googlesource.com/chromium/src/+/9b658f03a5e60309e3e430810ecfaec6886cbadb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/metrics/actions/actions.xml View 1 chunk +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
dgn
PTAL
3 years, 8 months ago (2017-04-05 14:05:57 UTC) #2
Alexei Svitkine (slow)
lgtm
3 years, 8 months ago (2017-04-05 14:40:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2804683002/1
3 years, 8 months ago (2017-04-05 15:25:49 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 15:39:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9b658f03a5e60309e3e430810ecf...

Powered by Google App Engine
This is Rietveld 408576698